Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `self-closing-comp`: consider JSXMemberExpression as component too #2572

Merged

Conversation

@Belco90
Copy link
Contributor

Belco90 commented Feb 14, 2020

PR checklist

  • Addresses an existing issue

  • bugfix

  • Includes tests

  • Documentation update

Overview of change:

Compound components syntax was not considered in self-closing-comp rule. This PR include this syntax in the rule by adding JSXMemberExpression as valid components to be checked.

@ljharb
ljharb approved these changes Feb 15, 2020
@ljharb ljharb force-pushed the Belco90:pr/self-closing-comp__jsx-member-expression branch from b0d62d6 to 9b5d6aa Feb 15, 2020
@ljharb ljharb changed the title fix(self-closing-comp): consider JSXMemberExpression as component too [Fix] `self-closing-comp`: consider JSXMemberExpression as component too Feb 15, 2020
@ljharb ljharb added the bug label Feb 15, 2020
@ljharb ljharb merged commit 9b5d6aa into yannickcr:master Feb 15, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.584%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.