Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
[tests] delete test cases that became parsing error after firstname.lastname@example.org #2583
CI is failing after the release of email@example.com, 4 days ago, which is a dependency of espree. https://github.com/acornjs/acorn-jsx/releases/tag/5.2.0. That release introduced a breaking change that forbids
This PR removed test cases that became parsing error after firstname.lastname@example.org.
An expensive alternative is to setup tests for both acorn-jsx < 5.2.0 and > 5.2.0. But that is expensive.
I've gone ahead and updated the tests so they're kept when acorn-jsx is < 5.2, and skipped when it's absent or when it's >= 5.2. That way they can still run on eslint 4, for example: https://travis-ci.org/yannickcr/eslint-plugin-react/builds/657558888