Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] delete test cases that became parsing error after acorn-jsx@5.2.0 #2583

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@golopot
Copy link
Contributor

golopot commented Mar 1, 2020

CI is failing after the release of acorn-jsx@5.2.0, 4 days ago, which is a dependency of espree. https://github.com/acornjs/acorn-jsx/releases/tag/5.2.0. That release introduced a breaking change that forbids > and } in JSXText. Therefore codes like <p>></p> became a parsing error.

This PR removed test cases that became parsing error after acorn-jsx@5.2.0.

An expensive alternative is to setup tests for both acorn-jsx < 5.2.0 and > 5.2.0. But that is expensive.

… errors in acorn-jsx@5.2.0

Co-authored-by: Chiawen Chen <golopot@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb
Copy link
Collaborator

ljharb commented Mar 1, 2020

Has an issue been filed upstream for the breaking change in a minor release?

@ljharb
Copy link
Collaborator

ljharb commented Mar 2, 2020

Looks like they unfortunately made an intentional breaking change in a minor version.

@ljharb ljharb force-pushed the golopot:fix-tests-in-no-unescaped-entries branch from 4399661 to 241611c Mar 3, 2020
@ljharb
Copy link
Collaborator

ljharb commented Mar 3, 2020

I've gone ahead and updated the tests so they're kept when acorn-jsx is < 5.2, and skipped when it's absent or when it's >= 5.2. That way they can still run on eslint 4, for example: https://travis-ci.org/yannickcr/eslint-plugin-react/builds/657558888

@ljharb
ljharb approved these changes Mar 3, 2020
@ljharb ljharb force-pushed the golopot:fix-tests-in-no-unescaped-entries branch from 241611c to e231f44 Mar 3, 2020
@ljharb ljharb merged commit e231f44 into yannickcr:master Mar 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.608%
Details
@golopot golopot deleted the golopot:fix-tests-in-no-unescaped-entries branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.