Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Move "semver" to devDependencies #2595

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@rajivshah3
Copy link
Contributor

rajivshah3 commented Mar 16, 2020

semver is listed in dependencies, but only seems to be used in this test and not in the plugin itself:

const semver = require('semver');

This PR moves it to devDependencies so that downstream projects don't have to include an unnecessary dependency.

@ljharb
ljharb approved these changes Mar 17, 2020
Copy link
Collaborator

ljharb left a comment

Thanks! This was my bad in #2583.

@ljharb ljharb merged commit 4ddf277 into yannickcr:master Mar 17, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.616%
Details
@rajivshah3 rajivshah3 deleted the rajivshah3:fix/semver-dep branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.