Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] support eslint v7 #2635

Merged
merged 2 commits into from May 12, 2020
Merged

[New] support eslint v7 #2635

merged 2 commits into from May 12, 2020

Conversation

@ljharb
Copy link
Collaborator

@ljharb ljharb commented May 7, 2020

No description provided.

@ljharb ljharb mentioned this pull request May 7, 2020
19 of 19 tasks complete
@ljharb ljharb force-pushed the ljharb:eslint7 branch from 46f6c58 to b74850b May 8, 2020
@toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented May 9, 2020

@ljharb
Would you mind if I fix tests and node.start?
ljharb#10

@ljharb ljharb force-pushed the ljharb:eslint7 branch 3 times, most recently from b2f1f14 to 1d0494f May 9, 2020
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 9, 2020
16 of 16 tasks complete
@ljharb
Copy link
Collaborator Author

@ljharb ljharb commented May 9, 2020

@toshi-toma i restored the test you'd removed; we shouldn't need to remove tests to get this shipped.

That test is the one failing CI, legitimately.

@toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented May 10, 2020

@ljharb

Oh. I understand.

I made a mistake that added the test into valid.
https://github.com/yannickcr/eslint-plugin-react/pull/2635/files#diff-f8e412f530183ea4c0e4bbfd3c3f2b0eR576-R587

We should remove the test from valid. then, should pass the failing test.

What is the cause...

The test failed with ESLint v6 too.

@toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented May 10, 2020

There is an issue -> #1673

@ljharb
Copy link
Collaborator Author

@ljharb ljharb commented May 12, 2020

ah, thanks, i understand - the test was incorrectly in "invalid" (#1673 would fix that and make it properly invalid), but the parse error in the test was making it be silently ignored.

@ljharb ljharb force-pushed the ljharb:eslint7 branch from 1d0494f to 35030a0 May 12, 2020
@ljharb ljharb merged commit 304590a into yannickcr:master May 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.621%
Details
@ljharb ljharb deleted the ljharb:eslint7 branch May 12, 2020
@tylerbutler tylerbutler mentioned this pull request May 27, 2020
8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants