Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] `jsx-handler-names`: add `checkInlineFunction` option #2761

Merged
merged 1 commit into from Aug 30, 2020

Conversation

@dididy
Copy link
Contributor

@dididy dididy commented Aug 20, 2020

Add checkInlineFunction option for jsx-handler-names rule

PR resolve #2586

@dididy dididy closed this Aug 20, 2020
@ljharb
Copy link
Collaborator

@ljharb ljharb commented Aug 20, 2020

If you end up submitting a new PR, please reopen and reuse this one, rather than creating a new one and leaving this one untouched. Thanks!

@dididy dididy changed the title 2차시도 Review react/jsx-handler-names should not flag arrow functions Aug 21, 2020
@dididy dididy reopened this Aug 21, 2020
@dididy dididy changed the title react/jsx-handler-names should not flag arrow functions [New] `jsx-handler-names`: add `checkInlineFunction` option Aug 24, 2020
docs/rules/jsx-handler-names.md Outdated Show resolved Hide resolved
lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
@dididy
Copy link
Contributor Author

@dididy dididy commented Aug 24, 2020

@ljharb Could you review this PR?

@roshcagra
Copy link

@roshcagra roshcagra commented Aug 27, 2020

What's left to do on this PR?

@ljharb
ljharb approved these changes Aug 30, 2020
@ljharb ljharb merged commit 9eb81bc into yannickcr:master Aug 30, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.496%
Details
@ljharb ljharb added the enhancement label Aug 30, 2020
@roshcagra
Copy link

@roshcagra roshcagra commented Sep 28, 2020

I'm trying this out on the new release and I don't think it identifies arrow functions without curly braces correctly - should I open a new issue?

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Sep 28, 2020

Thanks, a new issue, or a PR with failing test cases, would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.