Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `forbid-component-props`: Implemented support for "namespaced" components. #2767

Merged

Conversation

@mnn
Copy link

@mnn mnn commented Aug 24, 2020

I don't really know what I am doing. I have just looked at the structure of the node, added a test and updated code so the tests pass.

Fixes #2766.

…components

Fixes #2766.
@ljharb ljharb force-pushed the mnn:forbid-component-props--namespaced-components branch from 9b31ba8 to 3924844 Aug 30, 2020
Copy link
Collaborator

@ljharb ljharb left a comment

Thanks, this looks great! Made some small tweaks, but just one question:

lib/rules/forbid-component-props.js Outdated Show resolved Hide resolved
@ljharb ljharb changed the title [New] `forbid-component-props`: Implemented support for "namespaced" components. [Fix] `forbid-component-props`: Implemented support for "namespaced" components. Aug 30, 2020
@ljharb ljharb force-pushed the mnn:forbid-component-props--namespaced-components branch from 3924844 to 6a34b8e Aug 30, 2020
@ljharb
ljharb approved these changes Aug 30, 2020
@ljharb ljharb force-pushed the mnn:forbid-component-props--namespaced-components branch from 6a34b8e to d6ee945 Aug 30, 2020
@ljharb ljharb merged commit d6ee945 into yannickcr:master Aug 30, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 97.497%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.