Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] react/prefer-read-only-props fails if using Flow's $ReadOnly<T> #2770

Closed
wants to merge 3 commits into from
Closed

[Fix] react/prefer-read-only-props fails if using Flow's $ReadOnly<T> #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb4c1bd
Adds test
karolina-benitez Aug 26, 2020
e51b911
Fix indentation
karolina-benitez Aug 26, 2020
efd6cc3
Checks if prop is
karolina-benitez Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/prefer-read-only-props.js
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ function isFlowPropertyType(node) {
}

function isCovariant(node) {
return node.variance && node.variance.kind === 'plus';
return node.variance && node.variance.kind === 'plus' || node.parent.parent.parent.id && node.parent.parent.parent.id.name === '$ReadOnly';
}

// ------------------------------------------------------------------------------
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-read-only-props.js
View file
Open in desktop
Expand Up @@ -131,6 +131,19 @@ ruleTester.run('prefer-read-only-props', rule, {
name: PropTypes.string,
};
`
},
// Class component with typed props property wrapped in $ReadOnly
{
code: [
'type Props = $ReadOnly<{foo: number}>;',
'class Hello extends React.Component {',
' props: Props;',
' render () {',
' return <div>{this.props.foo}</div>;',
' }',
'}'
].join('\n'),
parser: parsers.BABEL_ESLINT
}
],

Expand Down