Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function-component-definition: ignore properties #2771

Merged
merged 1 commit into from Aug 30, 2020

Conversation

@stefan-wullems
Copy link
Contributor

@stefan-wullems stefan-wullems commented Aug 26, 2020

Fixes #2765

Fixes #2765.
@stefan-wullems stefan-wullems force-pushed the stefan-wullems:master branch from acced0e to a5b7dcf Aug 26, 2020
@stefan-wullems stefan-wullems requested a review from ljharb Aug 30, 2020
@stefan-wullems stefan-wullems force-pushed the stefan-wullems:master branch from 0a9c2cb to a8440c6 Aug 30, 2020
@ljharb
ljharb approved these changes Aug 30, 2020
@ljharb ljharb force-pushed the stefan-wullems:master branch 2 times, most recently from a00e067 to 20103c5 Aug 30, 2020
@ljharb ljharb merged commit 20103c5 into yannickcr:master Aug 30, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0004%) to 97.495%
Details
@wmertens
Copy link

@wmertens wmertens commented Aug 31, 2020

Well, the test cases this PR uses should all have been ignored based on PascalCase alone. I don't see a test for it in lib/rules/function-component-definition.js either.

@wmertens
Copy link

@wmertens wmertens commented Aug 31, 2020

(this was in reply to the issue, sorry, on phone)

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Aug 31, 2020

@wmertens yes, ignored because they're not PascalCase.

@wmertens
Copy link

@wmertens wmertens commented Aug 31, 2020

@ljharb no, they weren't ignored before this PR, this PR only adds being part of an object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.