Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect TypeScript types for destructured default prop values #2780

Merged
merged 1 commit into from Sep 7, 2020

Conversation

@sunghyunjo
Copy link
Contributor

@sunghyunjo sunghyunjo commented Sep 1, 2020

Fix : #2762

…prop values

Fixes #2762.
@sunghyunjo sunghyunjo changed the title #2762 Update: destructured default prop values #2762 Detect TypeScript types for destructured default prop values Sep 1, 2020
@sunghyunjo sunghyunjo changed the title #2762 Detect TypeScript types for destructured default prop values Detect TypeScript types for destructured default prop values Sep 1, 2020
Copy link
Collaborator

@ljharb ljharb left a comment

Can we add some tests with props like { foo, bar = '' }?

docs/rules/prop-types.md Show resolved Hide resolved
@sunghyunjo sunghyunjo force-pushed the sunghyunjo:issue/#2762 branch from 0f2fb5b to 28bc1b2 Sep 2, 2020
@ljharb ljharb force-pushed the sunghyunjo:issue/#2762 branch from 28bc1b2 to 9a569f7 Sep 7, 2020
@ljharb
ljharb approved these changes Sep 7, 2020
Copy link
Collaborator

@ljharb ljharb left a comment

Thanks, and congrats on your first contribution!

@ljharb ljharb merged commit 9a569f7 into yannickcr:master Sep 7, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 97.487%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.