Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `jsx-closing-bracket-location`: In `tag-aligned`, made a distinction between tabs and spaces #2796

Merged
merged 1 commit into from Sep 16, 2020

Conversation

@Moong0122
Copy link
Contributor

@Moong0122 Moong0122 commented Sep 16, 2020

To differentiate between tab and space, modified lib/rules/jsx-closing-bracket-location
and added test case in tests/lib/rules/jsx-closing-bracket-location.

PR fixes #756

…ction between tabs and spaces

Fixes ##756.
@Moong0122 Moong0122 changed the title [Fix] In tag-aligned, made a distinction between tabs and spaces #756 [Fix] In tag-aligned, made a distinction between tabs and spaces Sep 16, 2020
@ljharb
ljharb approved these changes Sep 16, 2020
Copy link
Collaborator

@ljharb ljharb left a comment

Seems reasonable, thanks!

@ljharb ljharb changed the title [Fix] In tag-aligned, made a distinction between tabs and spaces [Fix] `jsx-closing-bracket-location`: In `tag-aligned`, made a distinction between tabs and spaces Sep 16, 2020
@ljharb ljharb force-pushed the Moong0122:issue-756 branch from eda8e23 to 7434f19 Sep 16, 2020
@ljharb ljharb merged commit 7434f19 into yannickcr:master Sep 16, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.489%
Details
@Moong0122 Moong0122 deleted the Moong0122:issue-756 branch Sep 28, 2020
@Moong0122 Moong0122 restored the Moong0122:issue-756 branch Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.