Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-pascal-case: support namespace option #2917

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@Kev-Y-Huang
Copy link
Contributor

@Kev-Y-Huang Kev-Y-Huang commented Feb 3, 2021

Fixes #2914.

New feature allows users to ignore text after the dot for namespaced components such as Theme-UI's Styled component <Styled.h1>.

As part of the changes, also addressed some issues that I identified in the rule. Previously if a component was namespaced the text before the dot could be not camelcase and could even be non-alphanumeric.

@ehowey
Copy link

@ehowey ehowey commented Feb 5, 2021

Thanks for your work on this Ken! I want to be rid of these errors as quickly as possible!

@Kev-Y-Huang Kev-Y-Huang force-pushed the Kev-Y-Huang:issue-2914 branch 4 times, most recently from b5e64e1 to d905279 Feb 13, 2021
lib/rules/jsx-pascal-case.js Outdated Show resolved Hide resolved
@Kev-Y-Huang
Copy link
Contributor Author

@Kev-Y-Huang Kev-Y-Huang commented Feb 17, 2021

Hopefully my news changes are a bit more elegant than using error handling to implement the rule @ljharb

@ljharb ljharb force-pushed the Kev-Y-Huang:issue-2914 branch from 38f003b to acf7d62 Feb 23, 2021
@ljharb
ljharb approved these changes Feb 23, 2021
@ljharb ljharb merged commit acf7d62 into yannickcr:master Feb 23, 2021
43 checks passed
43 checks passed
@github-actions
Automatic Rebase
Details
@github-actions
Require “Allow Edits”
Details
@github-actions
matrix
Details
@github-actions
pretest
Details
@github-actions
readme
Details
@github-actions
latest majors (15, 7)
Details
@github-actions
posttest
Details
@github-actions
latest majors (15, 6)
Details
@github-actions
latest majors (15, 5)
Details
@github-actions
latest majors (15, 4)
Details
@github-actions
latest majors (14, 7)
Details
@github-actions
latest majors (14, 6)
Details
@github-actions
latest majors (14, 5)
Details
@github-actions
latest majors (14, 4)
Details
@github-actions
latest majors (13, 7)
Details
@github-actions
latest majors (13, 6)
Details
@github-actions
latest majors (13, 5)
Details
@github-actions
latest majors (13, 4)
Details
@github-actions
latest majors (12, 7)
Details
@github-actions
latest majors (12, 6)
Details
@github-actions
latest majors (12, 5)
Details
@github-actions
latest majors (12, 4)
Details
@github-actions
latest majors (11, 7)
Details
@github-actions
latest majors (11, 6)
Details
@github-actions
latest majors (11, 5)
Details
@github-actions
latest majors (11, 4)
Details
@github-actions
latest majors (10, 7)
Details
@github-actions
latest majors (10, 6)
Details
@github-actions
latest majors (10, 5)
Details
@github-actions
latest majors (10, 4)
Details
@github-actions
latest majors (9, 6)
Details
@github-actions
latest majors (9, 5)
Details
@github-actions
latest majors (9, 4)
Details
@github-actions
latest majors (8, 6)
Details
@github-actions
latest majors (8, 5)
Details
@github-actions
latest majors (8, 4)
Details
@github-actions
latest majors (7, 5)
Details
@github-actions
latest majors (7, 4)
Details
@github-actions
latest majors (6, 5)
Details
@github-actions
latest majors (6, 4)
Details
@github-actions
latest majors (5, 4)
Details
@github-actions
latest majors (4, 4)
Details
@github-actions
node 4+
Details
@Kev-Y-Huang Kev-Y-Huang deleted the Kev-Y-Huang:issue-2914 branch Feb 24, 2021
@LekoArts
Copy link

@LekoArts LekoArts commented Mar 5, 2021

Thanks for the PR @Kev-Y-Huang 👍

Hi @ljharb 👋 I sadly couldn't find any information on when you're releasing stuff. When can we expect this PR to be released / alternatively is there a nightly release?

With the documentation merged I assumed this is already published. Thanks!

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Mar 5, 2021

There is certainly no nightly release, and no schedule. It will be in the next release.

Merged never automatically implies released, in any project on GitHub. You should be checking the documentation on the latest tag for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants