Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] support eslint 8.x #3059

Merged
merged 1 commit into from Nov 10, 2021
Merged

[New] support eslint 8.x #3059

merged 1 commit into from Nov 10, 2021

Conversation

Co-authored-by: Micha毛l De Boey <info@michaeldeboey.be>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #3059 (12f33f6) into master (0f7e2e7) will not change coverage.
The diff coverage is 100.00%.

Current head 12f33f6 differs from pull request most recent head d0d5d90. Consider uploading reports for the commit d0d5d90 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3059   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         118      118           
  Lines        7914     7914           
  Branches     2833     2833           
=======================================
  Hits         7718     7718           
  Misses        196      196           
Impacted Files Coverage 螖
lib/rules/no-typos.js 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0f7e2e7...d0d5d90. Read the comment docs.

.github/workflows/node-4+.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ljharb ljharb marked this pull request as draft Aug 30, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-8 branch 2 times, most recently from a06affd to ca20fe6 Oct 12, 2021
@ykzts ykzts mentioned this pull request Oct 13, 2021
8 tasks
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-8 branch 2 times, most recently from 994b829 to 47e58c8 Oct 13, 2021
@ljharb ljharb mentioned this pull request Oct 18, 2021
22 tasks
@ljharb ljharb force-pushed the eslint-8 branch 2 times, most recently from 7a901f2 to c8d2d9f Oct 18, 2021
@ljharb
Copy link
Collaborator

@ljharb ljharb commented Oct 18, 2021

Seems like babel-eslint tests can't be run on eslint 8+.

I'll land some test refactors in master that makes conditional parsers easier to do.

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Oct 25, 2021

I've rebased this; the ~600 test failures are on node 12 (because it's using typescript-eslint/parser v4 latest instead of v4.0), and node 14+ (because it's using v5).

I think we need to update the TS eslint parser in a separate PR, and get those test failures resolved, and then we can rebase this again.

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Oct 30, 2021

Locally I've got 3 test failures left - 2 are likely a bug in babel's eslint parser, the third is eslint/eslint#15234.

@ljharb ljharb changed the title feat: support ESLint 8.x [New] support eslint 8.x Oct 30, 2021
@aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Nov 1, 2021

seems all the tests passed. 馃帀

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Nov 1, 2021

@aladdin-add yes, but we're still waiting for eslint-config-airbnb-base to be published, which is blocked on sarbbottam/eslint-find-rules#337.

moselhy
moselhy approved these changes Nov 8, 2021
@ljharb ljharb force-pushed the eslint-8 branch 3 times, most recently from 2f8b9ac to 3addf52 Nov 9, 2021
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review Nov 9, 2021
tests/lib/rules/no-deprecated.js Outdated Show resolved Hide resolved
ljharb
ljharb approved these changes Nov 10, 2021
@ljharb ljharb merged commit 9e12d2b into yannickcr:master Nov 10, 2021
220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants