Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] jsx-uses-vars ignores lowercase tag names #3070

Merged
merged 1 commit into from Sep 9, 2021

Conversation

@alanorozco
Copy link
Contributor

@alanorozco alanorozco commented Sep 8, 2021

Context: eslint/eslint#15040

ljharb
ljharb approved these changes Sep 9, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #3070 (5340e9d) into master (577cb64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3070   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         111      111           
  Lines        7525     7529    +4     
  Branches     2768     2769    +1     
=======================================
+ Hits         7332     7336    +4     
  Misses        193      193           
Impacted Files Coverage Δ
lib/rules/jsx-uses-vars.js 95.23% <100.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577cb64...5340e9d. Read the comment docs.

@ljharb ljharb merged commit 5340e9d into yannickcr:master Sep 9, 2021
123 checks passed
@alanorozco alanorozco deleted the patch-1 branch Sep 9, 2021
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Sep 18, 2021

Nice fix.

@mrtnzlml
Copy link
Contributor

@mrtnzlml mrtnzlml commented Sep 21, 2021

Hola @alanorozco! 👋 It seems like this PR caused a breaking change in a patch release, see: #3080

Could you please have a look? I am not sure what would be the right thing to do in this case. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants