Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prop-types propTypes: bail out unknown generic types inside func params #3076

Merged
merged 1 commit into from Sep 18, 2021

Conversation

@vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Sep 18, 2021

Fixes #3074

when const Comp = (props: NonReactGeneric<T>) => {...} proceed as usual instead of early return.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #3076 (227e967) into master (bd270fc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3076      +/-   ##
==========================================
- Coverage   97.43%   97.43%   -0.01%     
==========================================
  Files         111      111              
  Lines        7529     7522       -7     
  Branches     2769     2763       -6     
==========================================
- Hits         7336     7329       -7     
  Misses        193      193              
Impacted Files Coverage Δ
lib/util/propTypes.js 97.27% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd270fc...227e967. Read the comment docs.

@ljharb ljharb changed the title [Fix] prop-types propTypes: bail out unkown generic types inside func params [Fix] prop-types propTypes: bail out unknown generic types inside func params Sep 18, 2021
ljharb
ljharb approved these changes Sep 18, 2021
Copy link
Collaborator

@ljharb ljharb left a comment

Thanks!

lib/util/propTypes.js Show resolved Hide resolved
@ljharb ljharb merged commit 227e967 into yannickcr:master Sep 18, 2021
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants