Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
rsync methods was broken because the '--' change introduced in 1.53_0…
…3, prepare for release, add TODO about windows quoting
  • Loading branch information
salva committed Dec 7, 2011
1 parent ddcf423 commit cc2ba8f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
9 changes: 9 additions & 0 deletions Changes
@@ -1,5 +1,14 @@
Revision history for Perl extension Net::OpenSSH.

0.55 Dec 6, 2011
- solve regression from 0.53_03: rsync methods were broken
because the hostname was not being correctly removed from
the ssh command passed to rsync (bug report by Mithun
Ayachit)

0.54 Dec 4, 2011
- release as stable

0.53_05 Nov 23, 2011
- scp methods were broken when a user was given (bug report by
Andrew J. Slezak)
Expand Down
9 changes: 7 additions & 2 deletions lib/Net/OpenSSH.pm
@@ -1,6 +1,6 @@
package Net::OpenSSH;

our $VERSION = '0.53_05';
our $VERSION = '0.55';

use strict;
use warnings;
Expand Down Expand Up @@ -539,7 +539,9 @@ sub _make_rsync_call {
my $self = shift;
my $before = shift;
my @ssh_args = $self->_make_ssh_call($before);
pop @ssh_args; # rsync adds the target host itself
splice @ssh_args, -2, 1; # rsync adds the target host itself,
# remove it from the list leaving the
# double dash after it.
my $transport = join(' ', $self->_rsync_quote(@ssh_args));
my @args = ( $self->{_rsync_cmd},
-e => $transport,
Expand Down Expand Up @@ -4043,6 +4045,9 @@ upon: L<http://www.openssh.org/donations.html>.
- auto_discard_streams feature for mod_perl2 and similar environments
- add proper shell quoting for Windows (see
L<http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx>).
Send your feature requests, ideas or any feedback, please!
=head1 COPYRIGHT AND LICENSE
Expand Down

0 comments on commit cc2ba8f

Please sign in to comment.