New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSString should not contain StringSpan #96

Closed

ackava opened this issue Nov 8, 2023 · 0 comments

Assignees

Contributor

ackava commented Nov 8, 2023

We need to decide whether JSString should hold StringSpan or String.

StringSpan causes lot of reallocation as every .ToString will cause new string allocation, instead of reusing whole string.
Only function's source code is useful as StringSpan, as in JavaScript, we are not actually accessing source code anywhere in the script.
Function's toString should allocate string from original StringSpan and reuse it.

ackava self-assigned this

ackava added a commit that referenced this issue


          StringSpan Removed from JSString to reduce allocations #96

e30f424

ackava closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment