unknown directive "tcp" #27

Open
bwellsnc opened this Issue Mar 14, 2012 · 6 comments

Projects

None yet

2 participants

@bwellsnc

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version. I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds. Once it builds and I install the RPM, I get the "unknown directive" error. It shows the correct build options and lists the module in nginx -V. Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it. I build this on RHEL 6. Is there an issue with 1.0.13 or is there a particular version that this module works with only. Thanks!

Owner

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version. I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds. Once it builds and I install the RPM, I get the "unknown directive" error. It shows the correct build options and lists the module in nginx -V. Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it. I build this on RHEL 6. Is there an issue with 1.0.13 or is there a particular version that this module works with only. Thanks!


Reply to this email directly or view it on GitHub:
#27

I am placing my conf files in a conf.d directory. Below is my nginx.conf.

user nginx;
worker_processes 4;
worker_rlimit_nofile 10000;

error_log /var/log/nginx/error.log;
#error_log /var/log/nginx/error.log notice;
#error_log /var/log/nginx/error.log info;

pid /var/run/nginx.pid;

events {
worker_connections 1024;
use epoll;
}

http {
include /etc/nginx/mime.types;
default_type application/octet-stream;

log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                  '$status $body_bytes_sent "$http_referer" '
                  '"$http_user_agent" "$http_x_forwarded_for"';

access_log  /var/log/nginx/access.log  main;

server_names_hash_bucket_size 64;

sendfile        on;
tcp_nopush      on;
tcp_nodelay     on;
server_tokens   off;
gzip            on;
gzip_static     on;
gzip_comp_level 5;
gzip_min_length 1024;
keepalive_timeout  65;
limit_zone   myzone  $binary_remote_addr  10m;

# Load config files from the /etc/nginx/conf.d directory
include /etc/nginx/conf.d/*.conf;

server {
    limit_conn   myzone  10;
    listen       80;
    server_name  _;

    #charset koi8-r;

    #access_log  logs/host.access.log  main;

    location / {
        root   /usr/share/nginx/html;
        index  index.html index.htm;
    }

    error_page  404              /404.html;

    location = /404.html {
        root   /usr/share/nginx/html;
    }

    # redirect server error pages to the static page /50x.html
    #
    error_page   500 502 503 504  /50x.html;
    location = /50x.html {
        root   /usr/share/nginx/html;
    }

    # proxy the PHP scripts to Apache listening on 127.0.0.1:80
    #
    #location ~ \.php$ {
    #    proxy_pass   http://127.0.0.1;
    #}

    # pass the PHP scripts to FastCGI server listening on 127.0.0.1:9000
    #
    #location ~ \.php$ {
    #    root           html;
    #    fastcgi_pass   127.0.0.1:9000;
    #    fastcgi_index  index.php;
    #    fastcgi_param  SCRIPT_FILENAME  /scripts$fastcgi_script_name;
    #    include        fastcgi_params;
    #}

    # deny access to .htaccess files, if Apache's document root
    # concurs with nginx's one
    #
    #location ~ /\.ht {
    #    deny  all;
    #}
}


# another virtual host using mix of IP-, name-, and port-based configuration
#
#server {
#    listen       8000;
#    listen       somename:8080;
#    server_name  somename  alias  another.alias;

#    location / {
#        root   html;
#        index  index.html index.htm;
#    }
#}


# HTTPS server
#
#server {
#    listen       443;
#    server_name  localhost;

#    ssl                  on;
#    ssl_certificate      cert.pem;
#    ssl_certificate_key  cert.key;

#    ssl_session_timeout  5m;

#    ssl_protocols  SSLv2 SSLv3 TLSv1;
#    ssl_ciphers  HIGH:!aNULL:!MD5;
#    ssl_prefer_server_ciphers   on;

#    location / {
#        root   html;
#        index  index.html index.htm;
#    }
#}

}

On Wed, Mar 14, 2012 at 9:43 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version.  I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds.  Once it builds and I install the RPM, I get the "unknown directive" error.  It shows the correct build options and lists the module in nginx -V.  Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it.  I build this on RHEL 6.  Is there an issue with 1.0.13 or is there a particular version that this module works with only.  Thanks!


Reply to this email directly or view it on GitHub:
#27


Reply to this email directly or view it on GitHub:
#27 (comment)

Owner

I don't see the tcp directive. Have you put this directive in the main
block. It's coordinate with the http directive.

If you do so, can you show me your rpm spec file?

On 2012/3/15 9:53, bwellsnc wrote:

I am placing my conf files in a conf.d directory. Below is my nginx.conf.

user nginx;
worker_processes 4;
worker_rlimit_nofile 10000;

error_log /var/log/nginx/error.log;
#error_log /var/log/nginx/error.log notice;
#error_log /var/log/nginx/error.log info;

pid /var/run/nginx.pid;

events {
worker_connections 1024;
use epoll;
}

http {
include /etc/nginx/mime.types;
default_type application/octet-stream;

 log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                   '$status $body_bytes_sent "$http_referer" '
                   '"$http_user_agent" "$http_x_forwarded_for"';

 access_log  /var/log/nginx/access.log  main;

 server_names_hash_bucket_size 64;

 sendfile        on;
 tcp_nopush      on;
 tcp_nodelay     on;
 server_tokens   off;
 gzip            on;
 gzip_static     on;
 gzip_comp_level 5;
 gzip_min_length 1024;
 keepalive_timeout  65;
 limit_zone   myzone  $binary_remote_addr  10m;

 # Load config files from the /etc/nginx/conf.d directory
 include /etc/nginx/conf.d/*.conf;

 server {
     limit_conn   myzone  10;
     listen       80;
     server_name  _;

     #charset koi8-r;

     #access_log  logs/host.access.log  main;

     location / {
         root   /usr/share/nginx/html;
         index  index.html index.htm;
     }

     error_page  404              /404.html;

     location = /404.html {
         root   /usr/share/nginx/html;
     }

     # redirect server error pages to the static page /50x.html
     #
     error_page   500 502 503 504  /50x.html;
     location = /50x.html {
         root   /usr/share/nginx/html;
     }

     # proxy the PHP scripts to Apache listening on 127.0.0.1:80
     #
     #location ~ \.php$ {
     #    proxy_pass   http://127.0.0.1;
     #}

     # pass the PHP scripts to FastCGI server listening on 127.0.0.1:9000
     #
     #location ~ \.php$ {
     #    root           html;
     #    fastcgi_pass   127.0.0.1:9000;
     #    fastcgi_index  index.php;
     #    fastcgi_param  SCRIPT_FILENAME  /scripts$fastcgi_script_name;
     #    include        fastcgi_params;
     #}

     # deny access to .htaccess files, if Apache's document root
     # concurs with nginx's one
     #
     #location ~ /\.ht {
     #    deny  all;
     #}
 }


 # another virtual host using mix of IP-, name-, and port-based configuration
 #
 #server {
 #    listen       8000;
 #    listen       somename:8080;
 #    server_name  somename  alias  another.alias;

 #    location / {
 #        root   html;
 #        index  index.html index.htm;
 #    }
 #}


 # HTTPS server
 #
 #server {
 #    listen       443;
 #    server_name  localhost;

 #    ssl                  on;
 #    ssl_certificate      cert.pem;
 #    ssl_certificate_key  cert.key;

 #    ssl_session_timeout  5m;

 #    ssl_protocols  SSLv2 SSLv3 TLSv1;
 #    ssl_ciphers  HIGH:!aNULL:!MD5;
 #    ssl_prefer_server_ciphers   on;

 #    location / {
 #        root   html;
 #        index  index.html index.htm;
 #    }
 #}

}

On Wed, Mar 14, 2012 at 9:43 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version. I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds. Once it builds and I install the RPM, I get the "unknown directive" error. It shows the correct build options and lists the module in nginx -V. Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it. I build this on RHEL 6. Is there an issue with 1.0.13 or is there a particular version that this module works with only. Thanks!


Reply to this email directly or view it on GitHub:

#27

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:
#27 (comment)

I was trying to place the tcp variable in a file located in the conf.d
file. What I did is below. So I have to place this in the main
nginx.conf file. Thanks!

tcp {

upstream cluster {
   server 127.0.0.1:3306;

   check interval=3000 rise=2 fall=5 timeout=1000;
    }

server {
listen 8888;

proxy_pass cluster;
}

On Wed, Mar 14, 2012 at 9:57 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

I don't see the tcp directive. Have you put this directive in the main
block. It's coordinate with the http directive.

If you do so, can you show me your rpm spec file?

On 2012/3/15 9:53, bwellsnc wrote:

I am placing my conf files in a conf.d directory. Below is my nginx.conf.

user nginx;
worker_processes 4;
worker_rlimit_nofile 10000;

error_log /var/log/nginx/error.log;
#error_log /var/log/nginx/error.log notice;
#error_log /var/log/nginx/error.log info;

pid /var/run/nginx.pid;

events {
worker_connections 1024;
use epoll;
}

http {
include /etc/nginx/mime.types;
default_type application/octet-stream;

 log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                   '$status $body_bytes_sent "$http_referer" '
                   '"$http_user_agent" "$http_x_forwarded_for"';

 access_log  /var/log/nginx/access.log  main;

 server_names_hash_bucket_size 64;

 sendfile        on;
 tcp_nopush      on;
 tcp_nodelay     on;
 server_tokens   off;
 gzip            on;
 gzip_static     on;
 gzip_comp_level 5;
 gzip_min_length 1024;
 keepalive_timeout  65;
 limit_zone   myzone  $binary_remote_addr  10m;

 # Load config files from the /etc/nginx/conf.d directory
 include /etc/nginx/conf.d/*.conf;

 server {
     limit_conn   myzone  10;
     listen       80;
     server_name  _;

     #charset koi8-r;

     #access_log  logs/host.access.log  main;

     location / {
         root   /usr/share/nginx/html;
         index  index.html index.htm;
     }

     error_page  404              /404.html;

     location = /404.html {
         root   /usr/share/nginx/html;
     }

     # redirect server error pages to the static page /50x.html
     #
     error_page   500 502 503 504  /50x.html;
     location = /50x.html {
         root   /usr/share/nginx/html;
     }

     # proxy the PHP scripts to Apache listening on 127.0.0.1:80
     #
     #location ~ \.php$ {
     #    proxy_pass   http://127.0.0.1;
     #}

     # pass the PHP scripts to FastCGI server listening on 127.0.0.1:9000
     #
     #location ~ \.php$ {
     #    root           html;
     #    fastcgi_pass   127.0.0.1:9000;
     #    fastcgi_index  index.php;
     #    fastcgi_param  SCRIPT_FILENAME  /scripts$fastcgi_script_name;
     #    include        fastcgi_params;
     #}

     # deny access to .htaccess files, if Apache's document root
     # concurs with nginx's one
     #
     #location ~ /\.ht {
     #    deny  all;
     #}
 }


 # another virtual host using mix of IP-, name-, and port-based configuration
 #
 #server {
 #    listen       8000;
 #    listen       somename:8080;
 #    server_name  somename  alias  another.alias;

 #    location / {
 #        root   html;
 #        index  index.html index.htm;
 #    }
 #}


 # HTTPS server
 #
 #server {
 #    listen       443;
 #    server_name  localhost;

 #    ssl                  on;
 #    ssl_certificate      cert.pem;
 #    ssl_certificate_key  cert.key;

 #    ssl_session_timeout  5m;

 #    ssl_protocols  SSLv2 SSLv3 TLSv1;
 #    ssl_ciphers  HIGH:!aNULL:!MD5;
 #    ssl_prefer_server_ciphers   on;

 #    location / {
 #        root   html;
 #        index  index.html index.htm;
 #    }
 #}

}

On Wed, Mar 14, 2012 at 9:43 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version. I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds. Once it builds and I install the RPM, I get the "unknown directive" error. It shows the correct build options and lists the module in nginx -V. Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it. I build this on RHEL 6. Is there an issue with 1.0.13 or is there a particular version that this module works with only. Thanks!


Reply to this email directly or view it on GitHub:

#27

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:
#27 (comment)


Reply to this email directly or view it on GitHub:
#27 (comment)

Owner

No, you are not. The tcp directive should be put out of http block. The
main block is the outermost block.

http {
include /etc/nginx/mime.types;
default_type application/octet-stream;

Load config files from the /etc/nginx/conf.d directory

 include/etc/nginx/conf.d/*.conf;

On 2012/3/15 10:03, bwellsnc wrote:

I was trying to place the tcp variable in a file located in the conf.d
file. What I did is below. So I have to place this in the main
nginx.conf file. Thanks!

tcp {

upstream cluster {
server 127.0.0.1:3306;

 check interval=3000 rise=2 fall=5 timeout=1000;
     }

server {
listen 8888;

proxy_pass cluster;
}

On Wed, Mar 14, 2012 at 9:57 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

I don't see the tcp directive. Have you put this directive in the main
block. It's coordinate with the http directive.

If you do so, can you show me your rpm spec file?

On 2012/3/15 9:53, bwellsnc wrote:

I am placing my conf files in a conf.d directory. Below is my nginx.conf.

user nginx;
worker_processes 4;
worker_rlimit_nofile 10000;

error_log /var/log/nginx/error.log;
#error_log /var/log/nginx/error.log notice;
#error_log /var/log/nginx/error.log info;

pid /var/run/nginx.pid;

events {
worker_connections 1024;
use epoll;
}

http {
include /etc/nginx/mime.types;
default_type application/octet-stream;

  log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                    '$status $body_bytes_sent "$http_referer" '
                    '"$http_user_agent" "$http_x_forwarded_for"';

  access_log  /var/log/nginx/access.log  main;

  server_names_hash_bucket_size 64;

  sendfile        on;
  tcp_nopush      on;
  tcp_nodelay     on;
  server_tokens   off;
  gzip            on;
  gzip_static     on;
  gzip_comp_level 5;
  gzip_min_length 1024;
  keepalive_timeout  65;
  limit_zone   myzone  $binary_remote_addr  10m;

  # Load config files from the /etc/nginx/conf.d directory
  include /etc/nginx/conf.d/*.conf;

  server {
      limit_conn   myzone  10;
      listen       80;
      server_name  _;

      #charset koi8-r;

      #access_log  logs/host.access.log  main;

      location / {
          root   /usr/share/nginx/html;
          index  index.html index.htm;
      }

      error_page  404              /404.html;

      location = /404.html {
          root   /usr/share/nginx/html;
      }

      # redirect server error pages to the static page /50x.html
      #
      error_page   500 502 503 504  /50x.html;
      location = /50x.html {
          root   /usr/share/nginx/html;
      }

      # proxy the PHP scripts to Apache listening on 127.0.0.1:80
      #
      #location ~ \.php$ {
      #    proxy_pass   http://127.0.0.1;
      #}

      # pass the PHP scripts to FastCGI server listening on 127.0.0.1:9000
      #
      #location ~ \.php$ {
      #    root           html;
      #    fastcgi_pass   127.0.0.1:9000;
      #    fastcgi_index  index.php;
      #    fastcgi_param  SCRIPT_FILENAME  /scripts$fastcgi_script_name;
      #    include        fastcgi_params;
      #}

      # deny access to .htaccess files, if Apache's document root
      # concurs with nginx's one
      #
      #location ~ /\.ht {
      #    deny  all;
      #}
  }


  # another virtual host using mix of IP-, name-, and port-based configuration
  #
  #server {
  #    listen       8000;
  #    listen       somename:8080;
  #    server_name  somename  alias  another.alias;

  #    location / {
  #        root   html;
  #        index  index.html index.htm;
  #    }
  #}


  # HTTPS server
  #
  #server {
  #    listen       443;
  #    server_name  localhost;

  #    ssl                  on;
  #    ssl_certificate      cert.pem;
  #    ssl_certificate_key  cert.key;

  #    ssl_session_timeout  5m;

  #    ssl_protocols  SSLv2 SSLv3 TLSv1;
  #    ssl_ciphers  HIGH:!aNULL:!MD5;
  #    ssl_prefer_server_ciphers   on;

  #    location / {
  #        root   html;
  #        index  index.html index.htm;
  #    }
  #}

}

On Wed, Mar 14, 2012 at 9:43 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version. I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds. Once it builds and I install the RPM, I get the "unknown directive" error. It shows the correct build options and lists the module in nginx -V. Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it. I build this on RHEL 6. Is there an issue with 1.0.13 or is there a particular version that this module works with only. Thanks!


Reply to this email directly or view it on GitHub:

#27

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:
#27 (comment)

Ok, got it now. Thanks again!

On Wed, Mar 14, 2012 at 10:13 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

No, you are not. The tcp directive should be put out of http block. The
main block is the outermost block.

http {
    include       /etc/nginx/mime.types;
    default_type  application/octet-stream;
 # Load config files from the /etc/nginx/conf.d directory
    include/etc/nginx/conf.d/*.conf;

On 2012/3/15 10:03, bwellsnc wrote:

I was trying to place the tcp variable in a file located in the conf.d
file. What I did is below.  So I have to place this in the main
nginx.conf file.  Thanks!

tcp {

      upstream cluster {
         server 127.0.0.1:3306;

         check interval=3000 rise=2 fall=5 timeout=1000;
         }
server {
      listen 8888;

      proxy_pass cluster;
      }

On Wed, Mar 14, 2012 at 9:57 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

I don't see the tcp directive. Have you put this directive in the main
block. It's coordinate with the http directive.

If you do so, can you show me your rpm spec file?

On 2012/3/15 9:53, bwellsnc wrote:

I am placing my conf files in a conf.d directory.  Below is my nginx.conf.

user  nginx;
worker_processes  4;
worker_rlimit_nofile 10000;

error_log   /var/log/nginx/error.log;
#error_log  /var/log/nginx/error.log  notice;
#error_log  /var/log/nginx/error.log  info;

pid        /var/run/nginx.pid;

events {
      worker_connections  1024;
      use epoll;
}

http {
      include       /etc/nginx/mime.types;
      default_type  application/octet-stream;

      log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                        '$status $body_bytes_sent "$http_referer" '
                        '"$http_user_agent" "$http_x_forwarded_for"';

      access_log  /var/log/nginx/access.log  main;

      server_names_hash_bucket_size 64;

      sendfile        on;
      tcp_nopush      on;
      tcp_nodelay     on;
      server_tokens   off;
      gzip            on;
      gzip_static     on;
      gzip_comp_level 5;
      gzip_min_length 1024;
      keepalive_timeout  65;
      limit_zone   myzone  $binary_remote_addr  10m;

      # Load config files from the /etc/nginx/conf.d directory
      include /etc/nginx/conf.d/*.conf;

      server {
          limit_conn   myzone  10;
          listen       80;
          server_name  _;

          #charset koi8-r;

          #access_log  logs/host.access.log  main;

          location / {
              root   /usr/share/nginx/html;
              index  index.html index.htm;
          }

          error_page  404              /404.html;

          location = /404.html {
              root   /usr/share/nginx/html;
          }

          # redirect server error pages to the static page /50x.html
          #
          error_page   500 502 503 504  /50x.html;
          location = /50x.html {
              root   /usr/share/nginx/html;
          }

          # proxy the PHP scripts to Apache listening on 127.0.0.1:80
          #
          #location ~ .php$ {
          #    proxy_pass   http://127.0.0.1;
          #}

          # pass the PHP scripts to FastCGI server listening on 127.0.0.1:9000
          #
          #location ~ .php$ {
          #    root           html;
          #    fastcgi_pass   127.0.0.1:9000;
          #    fastcgi_index  index.php;
          #    fastcgi_param  SCRIPT_FILENAME  /scripts$fastcgi_script_name;
          #    include        fastcgi_params;
          #}

          # deny access to .htaccess files, if Apache's document root
          # concurs with nginx's one
          #
          #location ~ /.ht {
          #    deny  all;
          #}
      }

      # another virtual host using mix of IP-, name-, and port-based configuration
      #
      #server {
      #    listen       8000;
      #    listen       somename:8080;
      #    server_name  somename  alias  another.alias;

      #    location / {
      #        root   html;
      #        index  index.html index.htm;
      #    }
      #}

      # HTTPS server
      #
      #server {
      #    listen       443;
      #    server_name  localhost;

      #    ssl                  on;
      #    ssl_certificate      cert.pem;
      #    ssl_certificate_key  cert.key;

      #    ssl_session_timeout  5m;

      #    ssl_protocols  SSLv2 SSLv3 TLSv1;
      #    ssl_ciphers  HIGH:!aNULL:!MD5;
      #    ssl_prefer_server_ciphers   on;

      #    location / {
      #        root   html;
      #        index  index.html index.htm;
      #    }
      #}

}

On Wed, Mar 14, 2012 at 9:43 PM, Weibin Yao(姚伟斌)
reply@reply.github.com
wrote:

Yes, can you show me your nginx.conf?

On 2012/3/15 3:50, bwellsnc wrote:

Nginx version: 1.0.13

I am building an rpm version of nginx using the latest stable version.  I have a patch directive in my spec file pointing to the tcp.patch file and I get no errors when it builds.  Once it builds and I install the RPM, I get the "unknown directive" error.  It shows the correct build options and lists the module in nginx -V.  Nginx does not seem to have a problem and starts and runs fine until I create a config file that has the tcp option in it.  I build this on RHEL 6.  Is there an issue with 1.0.13 or is there a particular version that this module works with only.  Thanks!


Reply to this email directly or view it on GitHub:

#27

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:

#27 (comment)

Reply to this email directly or view it on GitHub:
#27 (comment)


Reply to this email directly or view it on GitHub:
#27 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment