Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor to public APIs for head/tail #54
In the template for ember-wormhole, use helpers that register an element to the parent wormhole component. The wormhole component can then use those elements to move to the target. This lessens the private APIs used by wormhole, but still uses private APIs to access the DOM or Fastboot SimpleDOM based on where the code is running. This could use all private API if we made SimpleDOM a dependency, but that would just inflate the JS payload with little benefit.
This unblocks Fastboot rendering. It will also mean dropping support for Ember versions before 1.13. See #47 for discussion.
Another pass at the implementation here for review. @krisselden I did not refactor
The ember-try config here is updated, perhaps travis needs a cache flush.
I'll flesh out the docs changes later today.
This is pretty wrapped up- @bantic can you please confirm with your fastboot demo app that this PR functions correctly?
I'm actually quite curious what will happen upon initial re-render of the page. The idea for fastboot users might be that the nodes inside that part of the page are destroyed and re-rendered. But we should know what is happening for sure.
referenced this pull request
Jun 6, 2016
Pushed the demo app to Heroku: https://ember-wormhole-fastboot-demo.herokuapp.com/