Convert TweetyNet to Pytorch model #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer import TweetyNet class
- now the only REQUIRED dependency is torch and attrs (for config)
- move 'vak' and 'crowsetta' dependencies to EXTRAS['article']
+ i.e. you can make an instance of the model with just torch,
but if you want to recreate the article you need all the other
libraries
- fix/add entry points
- add pytest dependency for EXTRAS['test'] in setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because Tensorflow 1.0 is deprecated.
Chose PyTorch over Tensorflow 2.0 for several reasons, see https://github.com/NickleDave/vak/pull/88
vaka dependency, because:model.pyso that it subclassesvak.Modeland specifies optimizer, loss, metricsnetwork.pymodule withTweetyNetclass, that implements network as subclass oftorch.nn.Module