Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): update types for deno ^1.4.0 #100

Merged
merged 1 commit into from Oct 1, 2020

Conversation

@luke-john
Copy link
Contributor

@luke-john luke-john commented Sep 30, 2020

In version 1.4 Deno adopted;

This requires the use of;

  • type only imports for values which are only used as types (importsNotUsedAsValues)

I've added more details at yargs/yargs#1771.

related prs:

@bcoe
Copy link
Member

@bcoe bcoe commented Oct 1, 2020

@luke-john mind making this PR against the main branch, deno is created automatically.

In version 1.4 Deno adopted;

- the tsconfig setting [importsNotUsedAsValues](https://www.typescriptlang.org/tsconfig#importsNotUsedAsValues) - denoland/deno#7413

This requires the use of;
- type only imports for values which are only used as types (`importsNotUsedAsValues`)
@luke-john luke-john force-pushed the YARGS-1771_support-new-deno-version branch from bb2610a to 230f690 Oct 1, 2020
@luke-john luke-john changed the base branch from deno to master Oct 1, 2020
@luke-john
Copy link
Contributor Author

@luke-john luke-john commented Oct 1, 2020

Updated to be target master (with the ci commit on the deno branch removed). cheers.

bcoe
bcoe approved these changes Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants