Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: drops Node 6 and 4. begin following Node.js LTS schedule #89

Merged
merged 5 commits into from Aug 4, 2020

Conversation

@QmarkC
Copy link
Contributor

@QmarkC QmarkC commented Jul 24, 2020

This skips the EOL Node 8, and moves us to Node 10 as the supported Node.js version for y18n.

@QmarkC QmarkC requested a review from bcoe Jul 24, 2020
@bcoe
Copy link
Member

@bcoe bcoe commented Jul 30, 2020

@QmarkC thanks for the update. One thing on my mind, as we move towards the next major of each of yargs' dependencies, is if we can prefect the approach here then we should be able to ship a version of yargs that is fully functional in Node ESM, Node CJS, browser ESM, and Deno...

This is completely unrelated to dropping old Node.js versions, except that I'd like to hold off on us taking the next breaking change for these libraries until we've dialed in the approach I'm describing.

Copy link
Member

@bcoe bcoe left a comment

looks good to me, only piece of feedback is, let's standardize on actions.

.travis.yml Outdated
@@ -1,7 +1,9 @@
language: node_js
sudo: false
node_js:
- "4"
- "6"
- "10"
Copy link
Member

@bcoe bcoe Jul 30, 2020

as we dust off these old libraries, let's switch to GitHub actions, and add automated publication/releasing, see:

https://github.com/yargs/yargs-parser/tree/master/.github/workflows

I can update the release-please.yml with the publication logic, if you add ci.yml for testing.

package.json Outdated
},
"repository": {
"type": "git",
"url": "git@github.com:yargs/y18n.git"
},
"license": "ISC",
"author": "Ben Coe <ben@npmjs.com>",
Copy link
Member

@bcoe bcoe Jul 30, 2020

nit, but we should probably switch my email to bencoe@gmail.com.

bcoe
bcoe approved these changes Aug 4, 2020
Copy link
Member

@bcoe bcoe left a comment

thanks \o/

@bcoe
Copy link
Member

@bcoe bcoe commented Aug 4, 2020

@QmarkC I don't believe releases are setup on this repo yet, I'll do so and then merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants