Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boolean numeric short option #294

merged 4 commits into from Aug 5, 2020


Copy link

@QmarkC QmarkC commented Jul 20, 2020

Fixes #283 by adding a check to see if next option is a boolean alias.

@QmarkC QmarkC changed the title fix: boolean numeric short option (#283) fix: boolean numeric short option Jul 20, 2020
Copy link
Contributor Author

QmarkC commented Aug 3, 2020

@bcoe or @mleguen can one of you review this when you have the chance?

Copy link

@mleguen mleguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QmarkC !

Copy link

bcoe commented Aug 4, 2020

@QmarkC bother you to rebase now that I've landed the ESM refactor?

@bcoe bcoe merged commit f600082 into yargs:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Bug: different result for -x1 and -1x when -x and -1 are both booleans
3 participants