Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): address slow parse when using unknown-options-as-args #394

merged 5 commits into from Jun 20, 2021


Copy link

@bcoe bcoe commented Jun 20, 2021

@robmcl4 the recommended regex replacements in #386 don't quite work, because of the case of:


Instead I now capture and truncate a large number of leading -.

Fixes #386

Copy link
Member Author

bcoe commented Jun 20, 2021

@robmcl4 feel free to recommend additional test cases, this seemed to catch the examples you provided.

@bcoe bcoe changed the title fix(perf): address slow perf when using unknown-options-as-args fix(perf): address slow parse when using unknown-options-as-args Jun 20, 2021
@bcoe bcoe merged commit 441f059 into main Jun 20, 2021
@bcoe bcoe deleted the fix-386 branch June 20, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

ReDoS vulnerable when unknown-options-as-args is set
1 participant