Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getCompletion() no longer working for options #1495

merged 2 commits into from
Nov 27, 2019


Copy link

@mleguen mleguen commented Nov 27, 2019

getCompletion() throws when completing an option, as it needs parsed.aliases, which is lost (unfreezed) when calling .parse() with arguments.

See #1434

This is a side effect of fixing .parse() to be able to call it several times, a few months ago.

This PR provides parsed to completion before unfreezing it.

Mael LE GUEN added 2 commits November 27, 2019 18:02
As completion needs parsed.aliases to complete options
@bcoe bcoe merged commit 463feb2 into master Nov 27, 2019
@bcoe bcoe deleted the fix/1434-get-completion-no-longer-working-for-options branch November 27, 2019 19:08
Copy link

bcoe commented Nov 27, 2019

@mleguen thanks for the patch 👌

Copy link

bcoe commented Jan 2, 2020

@mleguen this should be out the door in 15.1.0 👌 thanks for all the hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants