Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate positionals when unknown-options-as-args is set #1508



Copy link

@mleguen mleguen commented Dec 4, 2019

Positionals where no longer populated using unknown-options-as-args, as yargs turned them into options before handing them to yargs, but withoud declaring the corresponding option. So they were handled by yargs-parser as unknown options.

The "hidden" options for the positionals are now declared when using unknown-options-as-args.

Closes #1444.

@bcoe bcoe merged commit bb0f2eb into master Dec 6, 2019
@bcoe bcoe deleted the fix/1444-positional-not-set-with-unknown-options-as-args branch December 6, 2019 00:35
Copy link

bcoe commented Dec 6, 2019

@mleguen great work 👍

Copy link

Would it be possible to release this? Thanks ahead of time!

Copy link

bcoe commented Jan 2, 2020

@kellyselden sorry for the slow turnaround, mind taking this for a spin?

Fun fact, 15.1.0 was released by the new fully automated process, merging the special release prs will result in a publication to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

<foo> syntax is now missing when unknown-options-as-args is on
3 participants