Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use process.defaultApp to detect built electron app #1536

merged 2 commits into from
Feb 5, 2020


Copy link

@mleguen mleguen commented Jan 29, 2020

If process.defaultApp is false (for built electron app), remove only the first element of process.argv (the app binary) and not the two first elements (node + the app script).

See electron/electron#4690 (comment) for mor info.

Solve part of #685

To remove only the first element of process.argv
@mleguen mleguen marked this pull request as ready for review January 29, 2020 20:36
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add the additional comment I noted, but otherwise this is looking great to me 👍

lib/process-argv.js Show resolved Hide resolved
@mleguen mleguen merged commit a8ce123 into master Feb 5, 2020
@mleguen mleguen deleted the 685-fix-electron-app-first-parameter-removed branch February 5, 2020 11:00
Copy link

bcoe commented Feb 5, 2020

@mleguen friendly reminder to make sure you use conventional commits when you merge, or else stuff doesn't show up in the next release, I went ahead and amended.

bcoe pushed a commit that referenced this pull request Feb 5, 2020
Use process.defaultApp to detect built electron app
Copy link
Member Author

mleguen commented Feb 6, 2020

@bcoe Oops! Sorry and thanks. Would you have a link to some doc about the requested commit syntax (is it the same as the one used by nest.js?) for me to do it as expected next time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants