Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop support for EOL Node 8 #1686

Merged
merged 3 commits into from
Jul 6, 2020
Merged

feat!: drop support for EOL Node 8 #1686

merged 3 commits into from
Jul 6, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jul 5, 2020

Drops support for end of life Node 8.

Notes:

  • yargs@15.4.0 was released a few days ago, which includes much of @mleguen's work migrating to TypeScript (we should be mindful that we might need to port a few fixes back to this release line.).
  • we should not release yargs@16.x.x until we've finished the full TypeScript conversion, this includes @QmarkC's work on yargs-parser.

@bcoe bcoe requested review from QmarkC and mleguen July 5, 2020 21:27
@@ -1,2 +0,0 @@
releaseType: node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this functionality was replaced with a GitHub Action.

if (process && process.version) {
const major = Number(process.version.match(/v([^.]+)/)[1])
if (major < minNodeVersion) {
throw Error(`yargs supports a minimum Node.js version of ${minNodeVersion}. Read our version support policy: https://github.com/yargs/yargs#supported-nodejs-versions`)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started throwing on unsupported versions of Node.js, otherwise folks can get bit somewhere down the road, e.g., when we pull in a feature like async generators, which aren't supported in Node 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant