Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move yargs.cjs to yargs #1747

Merged
merged 2 commits into from
Sep 10, 2020
Merged

fix: move yargs.cjs to yargs #1747

merged 2 commits into from
Sep 10, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 10, 2020

.cjs is not resolved by default in Node 10's resolution. .js is automatically interpreted as ESM when module is true

The hack of using no extension seems to allow us to continue exposing require('yargs/yargs) on both Node 14 and Node 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant