Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): get yargs working on deno@1.5.x #1799

Merged
merged 1 commit into from Nov 9, 2020
Merged

fix(deno): get yargs working on deno@1.5.x #1799

merged 1 commit into from Nov 9, 2020

Conversation

@bcoe
Copy link
Member

@bcoe bcoe commented Nov 9, 2020

This gets yargs working again on deno@1.5.x, by dropping the complex YargsInstance.

Unfortunately deno@1.5.x seems to break the already fragile path handling logic that was being used to target both Node.js and Deno simultaneously. I'm not sure what the best path forward is, we might want to simply maintain our own type definitions for deno?

Refs #1792
Fixes #1794

CC: @ffMathy @KhushrajRathod

@bcoe bcoe merged commit cb01c98 into master Nov 9, 2020
8 checks passed
8 checks passed
@github-actions
test (10)
Details
@github-actions
test (12)
Details
@github-actions
test (13)
Details
@github-actions
test (14)
Details
@github-actions
windows
Details
@github-actions
esm (14)
Details
@github-actions
deno
Details
@github-actions
coverage
Details
@bcoe bcoe deleted the deno-fix branch Nov 9, 2020
@KhushrajRathod
Copy link

@KhushrajRathod KhushrajRathod commented Nov 9, 2020

Hey, could you let me know when a Yargs release ships with these changes? Thanks!

@bcoe
Copy link
Member Author

@bcoe bcoe commented Nov 9, 2020

@KhushrajRathod there's one change I'd like to also fix before the release, hope to have something out within the next couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants