Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add package.json to module exports #1818

Merged
merged 1 commit into from Dec 4, 2020
Merged

chore: add package.json to module exports #1818

merged 1 commit into from Dec 4, 2020

Conversation

@toverux
Copy link
Contributor

@toverux toverux commented Dec 3, 2020

The reason for this change is explained in #1817.

TL;DR: yargs uses the package.json::exports field to define importable paths from the outside. Any files that are not explicitly listed in it cannot be required anymore. However, some tools may attempt to require(node_modules/yargs/package.json) to read package info and fail. This PR exposes the package.json file to the public.

Fixes #1817
@bcoe
bcoe approved these changes Dec 4, 2020
@bcoe bcoe merged commit d783a49 into yargs:master Dec 4, 2020
8 checks passed
8 checks passed
@github-actions
test (10)
Details
@github-actions
test (12)
Details
@github-actions
test (13)
Details
@github-actions
test (14)
Details
@github-actions
windows
Details
@github-actions
esm (14)
Details
@github-actions
deno
Details
@github-actions
coverage
Details
@toverux
Copy link
Contributor Author

@toverux toverux commented Dec 4, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants