Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): positional arguments completion #2090

Merged
merged 4 commits into from Jan 24, 2022

Conversation

zuozp8
Copy link
Contributor

@zuozp8 zuozp8 commented Dec 10, 2021

It will be convinient for reviewers to look at commits separately:

@bcoe
Copy link
Member

bcoe commented Dec 21, 2021

@zuozp8 thank you for the contribution 👏 will provide review as soon as possible.

@zuozp8 zuozp8 force-pushed the positional-completion branch from 80f2db8 to c195db4 Compare Jan 3, 2022
@zuozp8
Copy link
Contributor Author

zuozp8 commented Jan 3, 2022

@bcoe I rebased my branch as there were conflicts

I would be grateful if you could review (and release) it soon

Copy link
Member

@bcoe bcoe left a comment

This is looking good, I appreciate the tests being fleshed out.

test/completion.cjs Show resolved Hide resolved
test/completion.cjs Show resolved Hide resolved
test/completion.cjs Show resolved Hide resolved
lib/completion.ts Show resolved Hide resolved
@bcoe
Copy link
Member

bcoe commented Jan 17, 2022

I'll split choicesCompletions() into choicesFromOptionsCompletions() and choicesFromPositionalsCompletions()
Sounds like a plan to me.

@zuozp8 zuozp8 requested a review from bcoe Jan 20, 2022
bcoe
bcoe approved these changes Jan 24, 2022
@bcoe bcoe changed the title positional arguments completion feat(completion): positional arguments completion Jan 24, 2022
@bcoe bcoe merged commit 00e4ebb into yargs:main Jan 24, 2022
7 checks passed
@bcoe
Copy link
Member

bcoe commented Jan 24, 2022

@zuozp8 thank you for the great contribution.

@zuozp8 zuozp8 deleted the positional-completion branch Mar 17, 2022
@zuozp8
Copy link
Contributor Author

zuozp8 commented Mar 17, 2022

@bcoe could you make a release with my changes?

@bcoe
Copy link
Member

bcoe commented Mar 19, 2022

@zuozp8 it's released now with your changes, thanks for the great contributions, and sorry for the slow turnaround (it's been a very busy month.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants