Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing entries to published files #2185

Merged
merged 2 commits into from May 14, 2022
Merged

fix: add missing entries to published files #2185

merged 2 commits into from May 14, 2022

Conversation

hongaar
Copy link
Contributor

@hongaar hongaar commented May 12, 2022

Due to the yargs.mjs file not being published, the fix merged with #2151 is not effective yet. This change should fix that.

Cannot find module './node_modules/yargs/yargs.mjs' imported from ./cli.js

Edit: Also added missing browser.d.ts

Due to the `yargs.mjs` file not being published, the fix merged with yargs#2151 is not effective yet. This change should fix that.

```
Cannot find module './node_modules/yargs/yargs.mjs' imported from ./cli.js
```
@hongaar hongaar changed the title fix: missing yargs.mjs fix: add missing entries to package.json files May 12, 2022
@hongaar hongaar changed the title fix: add missing entries to package.json files fix: add missing entries to published files May 12, 2022
bcoe
bcoe approved these changes May 14, 2022
@bcoe bcoe merged commit 5685382 into yargs:main May 14, 2022
7 checks passed
@bcoe
Copy link
Member

@bcoe bcoe commented May 14, 2022

@hongaar thank you for catching this 👍

aside, what do you think of making yargs ESM only, when we drop Node 12?

@hongaar hongaar deleted the patch-1 branch May 16, 2022
@hongaar
Copy link
Contributor Author

@hongaar hongaar commented May 17, 2022

@bcoe reading some articles on the subject, it looks like this will be a breaking change since consuming ESM modules from CJS can't use require(). https://twitter.com/bradleymeck/status/1346824835494719490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants