Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Japanese translation #254

Merged
merged 1 commit into from Sep 14, 2015

Conversation

Projects
None yet
2 participants
@oti
Copy link
Contributor

commented Sep 13, 2015

No description provided.

@oti

This comment has been minimized.

Copy link
Owner Author

commented on locales/ja.json in f994490 Sep 14, 2015

I have no confidence in "Implications failed" translation. I cannot understand when this error exiting.

@bcoe

This comment has been minimized.

Copy link
Member

commented Sep 14, 2015

@oti this is awesome, thanks for the translation. The implication failed warning is caused by this:

var yargs  = require('./')
  .implies('a', 'b')
  .argv
Benjamins-MacBook-Pro:yargs benjamincoe$ ./test.js -a

Implications failed:
  a -> b

I'm going to land this translation, and if needed you can provide a patch that fixes any wording if need be.

bcoe added a commit that referenced this pull request Sep 14, 2015

@bcoe bcoe merged commit 4bffab2 into yargs:master Sep 14, 2015

3 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@oti oti deleted the oti:added-japanese-translation branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.