New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add korean translation #296

Merged
merged 2 commits into from Nov 14, 2015

Conversation

Projects
None yet
4 participants
@disjukr
Collaborator

disjukr commented Nov 14, 2015

No description provided.

@maxrimue

View changes

Show outdated Hide outdated locales/ko.json
"other": "알 수 없는 인자들입니다: %s"
},
"Invalid values:": "잘못된 값입니다:",
"Argument: %s, Given: %s, Choices: %s": "인자: $s, 입력받은 값: %s, 선택지: %s",

This comment has been minimized.

@maxrimue

maxrimue Nov 14, 2015

Member

You mixed in a $s there

@maxrimue

maxrimue Nov 14, 2015

Member

You mixed in a $s there

This comment has been minimized.

@disjukr

disjukr Nov 14, 2015

Collaborator

oh; thanks

@disjukr

disjukr Nov 14, 2015

Collaborator

oh; thanks

This comment has been minimized.

@disjukr

disjukr Nov 14, 2015

Collaborator

fixed

@disjukr

disjukr Nov 14, 2015

Collaborator

fixed

@sairion

This comment has been minimized.

Show comment
Hide comment
@sairion

sairion Nov 14, 2015

Looks good!

sairion commented Nov 14, 2015

Looks good!

@bcoe

This comment has been minimized.

Show comment
Hide comment
@bcoe

bcoe Nov 14, 2015

Member

Thanks for this contribution, I'm excited that we've gotten so many translations for yargs at this point \o/

I'm releasing yargs@3.30.0 today, I will work on getting this and #297 released in 3.31.0 this weekend too.

Member

bcoe commented Nov 14, 2015

Thanks for this contribution, I'm excited that we've gotten so many translations for yargs at this point \o/

I'm releasing yargs@3.30.0 today, I will work on getting this and #297 released in 3.31.0 this weekend too.

@disjukr

This comment has been minimized.

Show comment
Hide comment
@disjukr

disjukr Nov 14, 2015

Collaborator

yay \o/

Collaborator

disjukr commented Nov 14, 2015

yay \o/

@bcoe

This comment has been minimized.

Show comment
Hide comment
@bcoe

bcoe Nov 14, 2015

Member

@disjukr could you update https://github.com/bcoe/yargs#localelocale with the new translation too 👍

Member

bcoe commented Nov 14, 2015

@disjukr could you update https://github.com/bcoe/yargs#localelocale with the new translation too 👍

@disjukr

This comment has been minimized.

Show comment
Hide comment
@disjukr

disjukr Nov 14, 2015

Collaborator

done 👍

Collaborator

disjukr commented Nov 14, 2015

done 👍

bcoe added a commit that referenced this pull request Nov 14, 2015

Merge pull request #296 from disjukr/master
Add korean translation

@bcoe bcoe merged commit a721399 into yargs:master Nov 14, 2015

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@disjukr

This comment has been minimized.

Show comment
Hide comment
@disjukr

disjukr Nov 16, 2015

Collaborator

oh; i misunderstood the meaning of count (https://github.com/bcoe/yargs#yargs-even-counts-your-booleans)
i thought it means number. like --count=123
단계(level) may better than 숫자(number)

Collaborator

disjukr commented Nov 16, 2015

oh; i misunderstood the meaning of count (https://github.com/bcoe/yargs#yargs-even-counts-your-booleans)
i thought it means number. like --count=123
단계(level) may better than 숫자(number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment