Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add korean translation #296

Merged
merged 2 commits into from Nov 14, 2015
Merged

Add korean translation #296

merged 2 commits into from Nov 14, 2015

Conversation

disjukr
Copy link
Contributor

@disjukr disjukr commented Nov 14, 2015

No description provided.

"other": "알 수 없는 인자들입니다: %s"
},
"Invalid values:": "잘못된 값입니다:",
"Argument: %s, Given: %s, Choices: %s": "인자: $s, 입력받은 값: %s, 선택지: %s",
Copy link
Member

@maxrimue maxrimue Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mixed in a $s there

Copy link
Contributor Author

@disjukr disjukr Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh; thanks

Copy link
Contributor Author

@disjukr disjukr Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sairion
Copy link

sairion commented Nov 14, 2015

Looks good!

@bcoe
Copy link
Member

bcoe commented Nov 14, 2015

Thanks for this contribution, I'm excited that we've gotten so many translations for yargs at this point \o/

I'm releasing yargs@3.30.0 today, I will work on getting this and #297 released in 3.31.0 this weekend too.

@disjukr
Copy link
Contributor Author

disjukr commented Nov 14, 2015

yay \o/

@bcoe
Copy link
Member

bcoe commented Nov 14, 2015

@disjukr could you update https://github.com/bcoe/yargs#localelocale with the new translation too 👍

@disjukr
Copy link
Contributor Author

disjukr commented Nov 14, 2015

done 👍

bcoe added a commit that referenced this pull request Nov 14, 2015
@bcoe bcoe merged commit a721399 into yargs:master Nov 14, 2015
@disjukr
Copy link
Contributor Author

disjukr commented Nov 16, 2015

oh; i misunderstood the meaning of count (https://github.com/bcoe/yargs#yargs-even-counts-your-booleans)
i thought it means number. like --count=123
단계(level) may better than 숫자(number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants