Skip to content

Add korean translation - #296

Merged
bcoe merged 2 commits into
yargs:masterfrom
disjukr:master
Nov 14, 2015
Merged

bcoe merged 2 commits into
yargs:masterfrom
disjukr:master

Conversation

@disjukr

@disjukr disjukr commented Nov 14, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread locales/ko.json Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mixed in a $s there

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh; thanks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sairion

sairion commented Nov 14, 2015

Copy link
Copy Markdown

Looks good!

@bcoe

bcoe commented Nov 14, 2015

Copy link
Copy Markdown
Member

Thanks for this contribution, I'm excited that we've gotten so many translations for yargs at this point \o/

I'm releasing yargs@3.30.0 today, I will work on getting this and #297 released in 3.31.0 this weekend too.

@disjukr

disjukr commented Nov 14, 2015

Copy link
Copy Markdown
Contributor Author

yay \o/

@bcoe

bcoe commented Nov 14, 2015

Copy link
Copy Markdown
Member

@disjukr could you update https://github.com/bcoe/yargs#localelocale with the new translation too 👍

@disjukr

disjukr commented Nov 14, 2015

Copy link
Copy Markdown
Contributor Author

done 👍

bcoe added a commit that referenced this pull request Nov 14, 2015
@bcoe
bcoe merged commit a721399 into yargs:master Nov 14, 2015
@disjukr

disjukr commented Nov 16, 2015

Copy link
Copy Markdown
Contributor Author

oh; i misunderstood the meaning of count (https://github.com/bcoe/yargs#yargs-even-counts-your-booleans)
i thought it means number. like --count=123
단계(level) may better than 숫자(number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants