Rename zh.json to zh_CN.json#511
Conversation
This is for simplified Chinese so the correct locale should be zh_CN. For traditional Chinese it should be something like zh_HK or zh_TW.
|
@andyhu thank you. I have a concern though, this could break existing apps that were relying on the |
|
Hi @bcoe, I have the same concern. However I'm a Chinese native speaker and I've never used the locale string 'zh' since it's quite different between Traditional Chinese and Simplified Chinese. As Chinese we can understand both of them though. Or maybe we can change it until next major release after something like zh_TW is available? |
|
@andyhu let's just keep |
|
thanks @bcoe |
|
@andyhu mind submitting a pull with both files, then I can give you credit for the work when I merge. |
|
@andyhu give this a spin, I've landed your changes finally:
|
This is for simplified Chinese so the correct locale should be zh_CN. For traditional Chinese it should be something like zh_HK or zh_TW.