Skip to content

Rename zh.json to zh_CN.json#511

Closed
yf-hk wants to merge 1 commit into
yargs:masterfrom
yf-hk:patch-1
Closed

Rename zh.json to zh_CN.json#511
yf-hk wants to merge 1 commit into
yargs:masterfrom
yf-hk:patch-1

Conversation

@yf-hk

@yf-hk yf-hk commented May 20, 2016

Copy link
Copy Markdown

This is for simplified Chinese so the correct locale should be zh_CN. For traditional Chinese it should be something like zh_HK or zh_TW.

This is for simplified Chinese so the correct locale should be zh_CN. For traditional Chinese it should be something like zh_HK or zh_TW.
@coveralls

coveralls commented May 20, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e41cc24 on andyhu:patch-1 into 2a73ed4 on yargs:master.

@bcoe

bcoe commented May 20, 2016

Copy link
Copy Markdown
Member

@andyhu thank you. I have a concern though, this could break existing apps that were relying on the zh locale name; perhaps we should just have two locale files? zh.json and zh_CN.json?

@yf-hk

yf-hk commented May 20, 2016

Copy link
Copy Markdown
Author

Hi @bcoe, I have the same concern. However I'm a Chinese native speaker and I've never used the locale string 'zh' since it's quite different between Traditional Chinese and Simplified Chinese. As Chinese we can understand both of them though. Or maybe we can change it until next major release after something like zh_TW is available?

@bcoe

bcoe commented May 21, 2016

Copy link
Copy Markdown
Member

@andyhu let's just keep zh.json and zh_CN.json and in the next major we'll drop zh.json.

@yf-hk

yf-hk commented May 21, 2016

Copy link
Copy Markdown
Author

thanks @bcoe

@bcoe

bcoe commented May 21, 2016

Copy link
Copy Markdown
Member

@andyhu mind submitting a pull with both files, then I can give you credit for the work when I merge.

@maxrimue maxrimue mentioned this pull request May 27, 2016
10 tasks
@maxrimue maxrimue added the 5.x label May 27, 2016
@bcoe

bcoe commented Jun 1, 2016

Copy link
Copy Markdown
Member

@andyhu thank you for the contribution \o/ closing in favor of #519 which keeps zh.json, and adds zh_CN.json.

@bcoe bcoe closed this Jun 1, 2016
@bcoe

bcoe commented Aug 14, 2016

Copy link
Copy Markdown
Member

@andyhu give this a spin, I've landed your changes finally:

npm cache clear; npm i yargs@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants