Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extending config files breaks on node 0.10 #797

Merged
merged 1 commit into from Feb 25, 2017

Conversation

@stevezhu
Copy link
Collaborator

commented Feb 25, 2017

issue from #779

path.isAbsolute() not supported in node 0.10
use path.resolve() instead as mentioned in discussion in issue

@stevezhu stevezhu added bug hackillinois and removed bug labels Feb 25, 2017
@bcoe
bcoe approved these changes Feb 25, 2017
Copy link
Member

left a comment

awesome 👍

@bcoe bcoe merged commit b5fedbe into 7.x Feb 25, 2017
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@bcoe bcoe deleted the config-extends-fix branch Feb 25, 2017
@phated

This comment has been minimized.

Copy link

commented Feb 25, 2017

❤️ ❤️ @stevezhu and @bcoe!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.