Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CMakeLists.txt ready to release #1

Closed
3 tasks done
YarikTH opened this issue Jan 9, 2021 · 2 comments
Closed
3 tasks done

Make CMakeLists.txt ready to release #1

YarikTH opened this issue Jan 9, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@YarikTH
Copy link
Owner

YarikTH commented Jan 9, 2021

Current CMakeLists.txt is not ready to be used. Need some work to prepare it.
TODO:

  • setup install settings
  • support add_subdirectory usage (test if is the main project, disable tests and examples if not)
  • make sure all variables and options have prefix UREACT_

make sure all variables and options have prefix UREACT_

To make sure about the name of the options:
cmake -LA . | awk '{if(f)print} /-- Cache values/{f=1}' | grep -v '^CMAKE_' | grep -v '^ProcessorCount_'

Sample output:

build_examples:BOOL=ON
build_tests:BOOL=y

Need to add such a check in the Makefile as part of the repository sanity check.

@YarikTH YarikTH added the enhancement New feature or request label Jan 9, 2021
@YarikTH YarikTH added this to the 1.0.0 milestone Jan 9, 2021
@YarikTH YarikTH self-assigned this Jan 9, 2021
@YarikTH
Copy link
Owner Author

YarikTH commented Jun 17, 2021

Install would be added with a separate issue

@YarikTH YarikTH closed this as completed Jun 17, 2021
@YarikTH
Copy link
Owner Author

YarikTH commented Jun 17, 2021

Install target is added

@YarikTH YarikTH reopened this Jun 17, 2021
YarikTH added a commit that referenced this issue Jun 17, 2021
@YarikTH YarikTH closed this as completed Jun 17, 2021
@YarikTH YarikTH modified the milestones: 1.0.0, 0.1.0 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant