Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docsearch): only use active language #397

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
2 participants
@Haroenv
Copy link
Member

commented Mar 3, 2017

so the syntax changed a little as to what I expected, and this PR is needed to make sure that only the current language is shown in the result.

If the language isn't in the list of languages indexed by algolia (docsearch-configs)

cc @Daniel15

feat(docsearch): only use active language
so the syntax changed a little as to what I expected, and this PR is needed to make sure that only the current language is shown in the result.

If the language isn't in the list of languages indexed by algolia ([docsearch-configs](https://github.com/algolia/docsearch-configs/blob/master/configs/yarnpkg.json))

cc @Daniel15
@Haroenv

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2017

Without this patch searching will show all languages, instead of the current language. Could this be merged soon @Daniel15?

@Daniel15 Daniel15 merged commit b3e82b2 into yarnpkg:master Mar 4, 2017

1 check passed

deploy/netlify Deploy preview ready!
Details
@Daniel15

This comment has been minimized.

Copy link
Member

commented Mar 4, 2017

Thanks! Sorry for the delay.

@Haroenv Haroenv deleted the algolia:feat/docsearch branch Mar 4, 2017

@Haroenv

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2017

Great! Sorry for confusing the options previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.