Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of install script when using fish #981

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@JosephDuffy
Copy link
Contributor

JosephDuffy commented Jul 15, 2019

When adding ~/.yarn/bin to fish_user_paths the output message was inaccurate. This also means that "Please open another terminal where the yarn command will now be available." is not accurate (it will be available immediately), although I am unsure of the best way to structure the code to alter this output.

When adding ~/.yarn/bin to fish_user_paths the output message was inaccurate. This also means that "Please open another terminal where the \`yarn\` command will now be available." is not accurate (it will be available immediately), although I am unsure of the best way to structure the code to alter this output.
@DanBuild

This comment has been minimized.

Copy link
Contributor

DanBuild commented Jul 15, 2019

Deploy preview for yarnpkg ready!

Built with commit 22252b0

https://deploy-preview-981--yarnpkg.netlify.com

@Haroenv Haroenv requested a review from Daniel15 Jul 16, 2019
Copy link
Member

Daniel15 left a comment

Seems reasonable to me!

@Daniel15 Daniel15 merged commit 91a7d7d into yarnpkg:master Jul 21, 2019
1 check passed
1 check passed
netlify/yarnpkg/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.