Permalink
Branch: master
Commits on Feb 22, 2019
  1. Implements support for switching to berry in the cli (#7041)

    arcanis committed Feb 22, 2019
    * Implements support for switching to berry in the cli
    
    * Update CHANGELOG.md
    
    * Update policies.js
Commits on Feb 18, 2019
  1. fix(upgrade): Fix yarn upgrade when using --scope with exotic deps (#…

    rally25rs authored and arcanis committed Feb 18, 2019
    …7017)
    
    * fix(upgrade): Fix yarn upgrade when using --scope with exotic dependencies.
    
    Exotic dependencies (github urls for example) were not being unlocked from the lockfile when running
    `yarn upgrade --scope @whatever/` which was resulting in dependencies not being upgraded. This was
    due to trying to find the dep in the lockfile just by it's url instead of in `name@url` format.
    
    fixes #7016
    
    * updated changelog
Commits on Feb 7, 2019
  1. Include key info for "expected hoisted" invariant (#7009)

    jrwats authored and arcanis committed Feb 7, 2019
Commits on Feb 5, 2019
  1. refactor: remove unnecessary checks (#6955)

    DanielRuf authored and arcanis committed Feb 5, 2019
    * refactor: remove unnecessary checks
    
    * codestyle: remove unnecessary braces
    
    * refactor: revert change in Git resolver
  2. fix: drive letter casing for win32 pnp (#7007)

    codepunkt authored and arcanis committed Feb 5, 2019
    * fix: drive letter casing for win32 pnp
    
    * docs: changelog
Commits on Feb 2, 2019
  1. Don’t call `release` with an exit code (#6981)

    eelco authored and arcanis committed Feb 2, 2019
    * Don’t call `release` with an exit code
    
    The `release` signature is incorrect, because its first argument is a callback function that will be called when the release is done. By attaching it to the `run()` promise however, release will be called with the exit code as argument. When the exit code is `1`, the code will crash. 
    
    This is very rare, but we’re seeing this when calling yarn from another node process (and possibly killing it too soon):
    ```
    <redacted>/node_modules/yarn/lib/cli.js:78119
             callback();
             ^
     TypeError: callback is not a function
         at options.fs.rmdir (<redacted>/node_modules/yarn/lib/cli.js:78119:9)
         at FSReqWrap.oncomplete (fs.js:141:20)
    ```
    
    * Only resolve after releasing is done, improve type of `release`.
    
    Note that this slightly violates the type of runEventuallyWithFile, as
    the Promised resolved by the release callback might return an Error
    object. But since this error was also not handled before, it’s out of
    scope for the fix of this patch.
Commits on Feb 1, 2019
  1. Check os and platform even when engines is not present in package.json (

    MichaReiser authored and arcanis committed Feb 1, 2019
    #6976)
    
    * Check os and platform even when engines is not present in package.json
    
    * Use %checks to remove unnecessary null check
    
    * Update CHANGELOG.md
Commits on Jan 30, 2019
  1. Fix handling of non-offline errors (#6968)

    yan12125 authored and arcanis committed Jan 30, 2019
    * Fix handling of non-offline errors
    
    * Update CHANGELOG.md
  2. Treat the ignore-scripts in yarnrc as a synonym to the cli arg (#6983)

    MichaReiser authored and arcanis committed Jan 30, 2019
    * Treat the ignore-scripts in yarnrc as a synonym to the cli arg
    
    Allow users to specify `ignore-scripts true` in the `.yarnrc` as
    specified by the `npm-config`. It is treated the same
    as if the user specifies `--ignore-scripts true` in the `.yarnrc` or
    passes `--ignore-scripts` as cli arg.
    
    * Update Changelog
    
    * Update CHANGELOG.md
Commits on Jan 29, 2019
  1. fix(pnp): make sure pnp module is again the first preloaded module. (#…

    jdalton authored and arcanis committed Jan 29, 2019
    …6951)
    
    * fix(pnp): make sure pnp module is again the first preloaded module.
    
    * Update CHANGELOG.md
  2. refactor: remove unused imports (#6956)

    DanielRuf authored and arcanis committed Jan 29, 2019
Commits on Jan 26, 2019
  1. Add 1.14.0 to changelog (#6967)

    say25 authored and arcanis committed Jan 26, 2019
  2. 1.15.0-0

    arcanis committed Jan 26, 2019
  3. v1.14.0

    arcanis committed Jan 26, 2019
Commits on Jan 23, 2019
  1. Fix suggested command after unlinking a package (#6931)

    justinsacbibit authored and arcanis committed Jan 23, 2019
    * Fix suggested command after unlinking a package
    
    Fixes #937, #1957
    
    * Update en.js
    
    * Update CHANGELOG.md
    
    * Update CHANGELOG.md
Commits on Jan 21, 2019
  1. Update CHANGELOG.md

    arcanis committed Jan 21, 2019
  2. fix(pnp): make sure pnp module is the first preloaded module. (#6942)

    jdalton authored and arcanis committed Jan 21, 2019
    * fix(pnp): make sure pnp module is the first preloaded module.
    
    * Update CHANGELOG.md
Commits on Jan 14, 2019
  1. fix(pnp): make sure that the package locator is fetched with a traili…

    zregvart authored and arcanis committed Jan 14, 2019
    …ng slash (#6882)
    
    * fix(pnp): make sure that the package locator is...
    
    ... fetched with a trailing slash
    
    I could not get P'n'P working on a project using `critical`[1] and
    traced it down to a lookup of a package locator without a trailing
    slash.
    
    A `require('resolve').sync('fg-loadcss')` from `inline-critical`[2]
    would fail to resolve as the `locatorsByLocations` lookup in `.pnp.js`
    would be using a key without a trailing slash, i.e.:
    
    ```
    "../../.cache/yarn/v4/npm-inline-critical-4.0.7-3ffba6a869f39215c8bb00ed2dd6b872e7f98adc/node_modules/inline-critical"
    ```
    
    `findPackageLocator` is invoked with `location` parameter (notice no
    trailing slash):
    
    ```
    location = "/home/zregvart/.cache/yarn/v4/npm-inline-critical-4.0.7-3ffba6a869f39215c8bb00ed2dd6b872e7f98adc/node_modules/inline-critical"
    ```
    
    from `resolveToUnqualified` with parameters:
    
    ```
    request = "fg-loadcss/package.json"
    issuer = "/home/zregvart/.cache/yarn/v4/npm-inline-critical-4.0.7-3ffba6a869f39215c8bb00ed2dd6b872e7f98adc/node_modules/inline-critical"
    ```
    
    All starting from `loadNodeModulesSync` in `resolve`'s `sync.js`[3]
    that ends up having `absoluteStart` without the trailing slash.
    
    Not sure if this is the most correct way of fixing this issue, by just
    ensuring that the trailing slash needed for the lookup is added if
    missing.
    
    All tests from `yarn test` and from `packages/pkg-tests`
    `yarn jest yarn.test.js` pass, so it seems like a start.
    
    This is how to reproduce:
    
    package.json:
    ```json
    {
      "name": "require-failure",
      "version": "1.0.0",
      "main": "index.js",
      "license": "MIT",
      "scripts": {
        "install": "node --require ./.pnp.js index.js"
      },
      "devDependencies": {
        "critical": "^1.3.4"
      },
      "installConfig": {
        "pnp": true
      }
    }
    ```
    
    index.js:
    ```javascript
    require('critical').generate({
      inline: true,
      html: '<!DOCTYPE html><html><head><link rel="stylesheet" href="site.css"></head><body><h1>Hello</h1></body></html>'
    });
    ```
    
    site.css:
    ```css
    h1 { font-weight: bold; }
    ```
    
    Not sure how to create a package test from that example (sorry).
    
    [1] https://github.com/addyosmani/critical
    [2] https://github.com/bezoerb/inline-critical/blob/340db21f6a2454ed74ede7a0b317d4c4e177770d/index.js#L32
    [3] https://github.com/browserify/resolve/blob/254bb4029df2f8d20a33043dfabd8e5cabfa37df/lib/sync.js#L52
    
    * Update CHANGELOG.md
  2. Improve rendering of Chocolatey package description (#6899)

    pascalberger authored and arcanis committed Jan 14, 2019
    * Improve rendering of Chocolatey package description
    
    * Update yarn.nuspec
  3. Fixing dynamic require missing from webpack (#6908)

    thoov authored and arcanis committed Jan 14, 2019
    * Fixing dynamic require missing from webpack
    
    When running `yarn pack` with a bundledDependency yarn was throwing
    an error: An unexpected error occurred: "Cannot find module \".\"".
    
    This was due to yarn's cli.js being transpiled to on line 110321:
    
    ```
    var thePackage = !(function webpackMissingModule() { var e = new Error("Cannot find module \".\""); e.code = 'MODULE_NOT_FOUND'; throw e; }());
    ```
    
    This line comes from https://github.com/stefanpenner/hash-for-dep/blob/e849d3e2f0350810716a0e504c84603362229570/lib/pkg.js#L20
    and is a dynamic require. This commit impements a fix for this based on the guidence from webpack/webpack#4175 (comment)
    
    This code was originally added with #5966
    
    * Update CHANGELOG.md
  4. feat(policies): Use github access token when requesting releases (#6912)

    billyvg authored and arcanis committed Jan 14, 2019
    * feat(policies): Use github access token when requesting releases
    
    If the environment variable `GITHUB_TOKEN` is defined, append `?access_token=<GITHUB_TOKEN>` when requesting yarn releases from GitHub.
    
    Closes #6905
    
    * fix lint
    
    * Update CHANGELOG.md
Commits on Jan 7, 2019
  1. Fixes PnP detection across workspaces (#6878)

    arcanis committed Jan 7, 2019
    * Fixes PnP detection across workspaces
    
    * Update CHANGELOG.md
Commits on Jan 4, 2019
  1. Show problem path in invariant message (#6868)

    CGamesPlay authored and arcanis committed Jan 4, 2019
    Sometimes, `yarn add` will fail unexpectedly, and it leaves the cache in an invalid state. To cause your yarn cache to become corrupted:
    
    ```
    $ yarn add antd@3.11.6
    yarn add v1.12.3
    [1/4] 🔍  Resolving packages...
    [2/4] 🚚  Fetching packages...
    error https://registry.yarnpkg.com/event-stream/-/event-stream-3.3.6.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "Unexpected end of data"
    info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    
    $ yarn cache list
    yarn cache v1.12.3
    error An unexpected error occurred: "There should only be one folder in a package cache (got  )".
    info If you think this is a bug, please open a bug report with the information provided in "/Users/rpatterson/Projects/chess2/www2/client/yarn-error.log".
    info Visit https://yarnpkg.com/en/docs/cli/cache for documentation about this command.
    ```
    
    Note that the error message provides no information about how to resolve the error. This commit adds the problem path to the invariant message. Deleting this problem path will allow `yarn cache list` to work properly again.
    
    The root cause of this issue is yarn#6805 which has been closed. This commit does not resolve the issue, so that issue should likely be reopened.
  2. Update CHANGELOG.md

    arcanis committed Jan 4, 2019
  3. Fix generated .pnp.js compatibility with Node 6. (#6871)

    rwjblue authored and arcanis committed Jan 4, 2019
    * Fix generated .pnp.js compatibility with Node 6.
    
    Prior to these changes the generated `.pnp.js` file would use trailing
    commas for function invocations which is not allowed (and generates a
    parse error) under Node 6.
    
    This removes the offending trailing commas...
    
    * Update lint config for src/util/generate-pnp-map-api.tpl.js.
    
    This file does not get transpiled down for Node 4 compat like other
    files, so we cannot use `"trailingComma": "all"` configuration (the
    default prettier config for this repo).
Commits on Dec 21, 2018
  1. Fix Chocolatey log spam & bad nodejs-lts requirement (#6475)

    JonathanWolfe authored and Daniel15 committed Dec 21, 2018
    **Summary**
    
    Fixes #6439 
    
    The chocolately install has always been full of log spam due to an incorrectly written `/l*v` flag, but those logs are also unneeded since the output has no useful info so I just removed them (this can be reversed to just fix the flag if y'all really want it back).
    
    This also removes the bad `nodejs-lts` nuget dependency added in #5925. It now has no dependency, and instead logs out to inform the user to install node if it's missing.
    
    **Test plan**
    
    * `choco uninstall yarn`
    * Replace the `{VERSION}` and `{CHECKSUM}` placeholders manually or do a full build (I manually replaced)
    * `.\chocolateyinstall.ps1`
Commits on Dec 18, 2018
  1. Update CHANGELOG.md

    arcanis committed Dec 18, 2018
  2. 1.14.0-0

    arcanis committed Dec 18, 2018
  3. v1.13.0

    arcanis committed Dec 18, 2018
  4. Return semantic exit code for audit (#6819)

    antrew authored and arcanis committed Dec 18, 2018
Commits on Dec 14, 2018
  1. Stops unplugging packages when the install scripts are disabled (#6820)

    arcanis committed Dec 14, 2018
    * Stops unplugging packages when the install scripts are disabled
    
    * Update CHANGELOG.md
  2. Implements the pnp hook for the `resolve` package (#6816)

    arcanis committed Dec 14, 2018
    * Implements the pnp hook for the `resolve` package
    
    * Updates the changelog
  3. Properly reports network errors (#6817)

    arcanis committed Dec 14, 2018
    * Properly reports network errors
    
    * Updates the changelog
    
    * Fixes flow
Commits on Dec 11, 2018
  1. Add custom headers to tarball fetcher (#6756)

    Glavin001 authored and arcanis committed Dec 11, 2018
    * Add custom headers to tarball fetcher
    
    * Remove requestUrl argument from requestHeaders method
    
    * Load custom headers for tarball request from yarn config
Commits on Dec 9, 2018
  1. chore(pacakge): Update @zkochan/cmd-shim to version 3.1.0 (#6804)

    ExE-Boss authored and arcanis committed Dec 9, 2018