Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-interactive does not work for Node.js above v10.2.0 #5949

Open
negezor opened this issue Jun 7, 2018 · 8 comments

Comments

@negezor
Copy link

commented Jun 7, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
After the packages are selected, the installation hangs in place without further output

If the current behavior is a bug, please provide the steps to reproduce.

I updated my version of Node.js from v10.0.0 to v10.4.0, this behavior started from v10.2.0
Steps:

$ yarn upgrade-interactive --latest

I select packages for updating, I press enter and all

What is the expected behavior?
Updating packages

Please mention your node.js, yarn and operating system version.
Node.js: v10.4.0
Yarn: 1.7.0
Windows: 10

@ghost ghost assigned kaylie-alexa Jun 7, 2018

@ghost ghost added the triaged label Jun 7, 2018

@gluons

This comment has been minimized.

Copy link

commented Jul 25, 2018

Me too. It hangs. Can't stop it with Ctrl + C.

Node: v10.7.0
Yarn: 1.7.0
OS: Windows 10

@rally25rs

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

Going to close several other issues as duplicates of this one, since this seems to be the oldest issue that reports this.

From what I can tell it's specific to Windows + Node 10.

If someone who can consistently reproduce this can help debug, it would be appreciated!

@rally25rs

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

The best lead on tracking this down seems to be #6198 (comment)

pfeigl added a commit to pfeigl/yarn that referenced this issue Nov 5, 2018

Fixes potential freeze on win+node10 interactive upgrades (yarnpkg#5949)
There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.
@pfeigl

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

I could track this problem down to an old version of inquirer which is beeing used internally. Sent a PR to update to latest version, which seems to bring no incompatibilities but fixes the problem.

pfeigl added a commit to pfeigl/yarn that referenced this issue Nov 5, 2018

Fixes potential freeze on win+node10 interactive upgrades (yarnpkg#5949)
There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.

arcanis added a commit that referenced this issue Nov 5, 2018

Fixes potential freeze on win+node10 interactive upgrades (#5949) (#6635
)

* Fixes potential freeze on win+node10 interactive upgrades (#5949)

There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.

* Update CHANGELOG.md
@heyimalex

This comment has been minimized.

Copy link

commented Nov 5, 2018

I know this has been merged, but just confirming that running upgrade-interactive off head works for me now!

@kallaspriit

This comment has been minimized.

Copy link

commented Nov 6, 2018

Had the same issue with the latest stable of 1.12.1, works with nightly 1.13.0 version.

@pfeigl

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

1.12.3 has been released which contains this fix. I think this issue can be closed.

Thanks at the wonderful yarn team for bringing this in so super fast!

@krnlde

This comment has been minimized.

Copy link

commented Feb 7, 2019

@contributors: Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.