Fix: Ensure valid target passed to fs.symlink (refs #3276) #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
requested changes
Jul 18, 2017
src/util/fs.js
Outdated
| } else { | ||
| relative = path.relative(path.dirname(dest), src); | ||
| relative = path.relative(path.dirname(dest), src) || '.'; | ||
| } | ||
| await fsSymlink(relative, dest); |
There was a problem hiding this comment.
Do await fsSymlink(relative || '.', dest); instead?
Also please add a comment above why we default to '.' (basically, the summary of this PR as a comment :))
BYK
changed the title
`path.relative` returns an empty string for the current directory. This was being passed as the target to `fs.symlink`. Changed it so '.' is passed instead in these cases.
|
Changes made 👍 |
arcanis
approved these changes
Jul 19, 2017
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
path.relativereturns an empty string for the current directory. This was being passed as the target tofs.symlink. Changed it so '.' is passed instead in these cases. Fixes issue #3276.Test plan
The fix is very small and straightforward so haven't added a test. Can do if needed.