Added missing pre/post hooks for pack (#4177)
#4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
Aug 18, 2017
|
Thanks a lot! |
|
Nice! Man, I should really get around to implementing my RFC relating to the hooks. |
yhatt
added a commit
to yhatt/markdown-it-incremental-dom
that referenced
this pull request
Dec 30, 2017
`yarn publish` is already supported prepack script in yarn 1.0.0. (and prepublish scripts is running before packing in yarn 1.2.0) See: yarnpkg/yarn#4193 yarnpkg/yarn#4553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yarn wouldn't run the
prepackandpostpackscripts, as it is expected whenpackis ran (#4177).This PR adds those missing calls and updates tests accordingly.
Test plan
Added tests.