chore(tests): Make integration tests passing on Node 7 #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act-scripts is not compatible with it, this skips test on node v7 which is used within yarn's Docker.
Summary of all failing tests
FAIL __tests__/integration.js (182.903s)
● yarn add react-scripts@1.0.13
expect(received).not.toMatch(expected)
Expected value not to match:
/^warning /gm
Received:
"warning You are using Node \"7.10.1\" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: \"^4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0\""
at __tests__/integration.js:82:1793
at Generator.next (<anonymous>)
at step (node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
at process._tickCallback (internal/process/next_tick.js:109:7)
viatsko
changed the title
BYK
requested changes
Oct 2, 2017
__tests__/integration.js
Outdated
| @@ -60,7 +60,8 @@ addTest('https://github.com/yarnpkg/yarn/releases/download/v0.18.1/yarn-v0.18.1. | |||
| addTest('https://github.com/bestander/chrome-app-livereload.git'); // no package.json | |||
| addTest('bestander/chrome-app-livereload'); // no package.json, github, tarball | |||
| // Only run `react-scripts` test on Node 6+ | |||
| if (parseInt(process.versions.node.split('.')[0], 10) >= 6) { | |||
| const nodeMajorVersion = parseInt(process.versions.node.split('.')[0], 10); | |||
There was a problem hiding this comment.
We still support Node 4 AFAIK. I think a better option would be to add the --no-node-version-check option to yarn invocations.
Just to clarify, the alternative is what I mentioned in the inline comment. |
arcanis
changed the title
… to make it work on node v4
…ke it work on node v4
|
OK, this is done. Altered function signature ( |
BYK
approved these changes
Oct 5, 2017
BYK
changed the title
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
**Summary** The change introduced in 96c215c caused tests to fail on node 7 as react-scripts is not compatible with it. This patch adds `--ignore-engines` flag to suppress the warning. **Test plan** Tests should pass on Node 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in 96c215c caused tests to fail on node 7 as react-scripts is not compatible with it, this skips test on node v7 which is used within yarn's Docker.
I excluded this test for node v7, here's the reasoning behind it:
Node 7.x is no longer supported, so this should be completely fine.