Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message to user when publishing fails #5771

Merged
merged 1 commit into from May 2, 2018
Merged

Show error message to user when publishing fails #5771

merged 1 commit into from May 2, 2018

Conversation

sth
Copy link
Contributor

@sth sth commented May 2, 2018

Summary

When publishing a package with yarn publish fails, yarn catches the error and shows "Couldn't publish package.". That's not very useful to diagnose the problem.

With this change, it additionally shows the message of the caught error, for example for a truncated .tgz file:

error Couldn't publish package: "https://registry.yarnpkg.com/somepackage: unexpected end of file"

Test plan

No actual functionality changed, only the error message got expanded. The tests still pass.

@arcanis
Copy link
Member

arcanis commented May 2, 2018

lgtm 👍

@arcanis arcanis merged commit a35a4f9 into yarnpkg:master May 2, 2018
@sth sth deleted the show-publish-error branch May 2, 2018 14:47
BYK pushed a commit to imsnif/yarn that referenced this pull request May 22, 2018
@edmorley
Copy link
Contributor

Thank you for this - we've lately had a number of strange failures in CI that were impossible to debug with the previous lack of error message! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants