Fixes to PR 6007 #6207
Merged
Fixes to PR 6007 #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false via --no-default-rc
|
Thanks! I think testing this would imply:
|
|
@arcanis, I have the basis of a test but cannot figure out how to generate and populate |
|
@arcanis - I've added a test for I think this concludes the PR. |
|
Perfect, thanks! |
arcanis
pushed a commit
that referenced
this pull request
Aug 3, 2018
* fix: ensure enableDefaultRc defaults to true unless exlicitly set to false via --no-default-rc * fix: ensure enableDefaultRc and extraneousYarnrcFiles are passed to config.init(...) * add: added test for yarn global add for module using a scoped registry
This was referenced Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a result of changes introduced in PR #6007 this PR resolves #6174 and provides a different implementation to #6181.
Test plan
All existing tests pass, PR #6007 added a number of tests but it seems the case of
yarn global ...with scoped registries was not tested. I cannot identify exactly how or where these tests should be done. I'd be happy to do them if I'm pointed in the right direction.