Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create handler for 3xx pages #181

Merged
merged 1 commit into from Jan 5, 2017
Merged

Conversation

JCotton1123
Copy link
Contributor

Add support for customizing handling of 3xx pages.

@s17t
Copy link
Contributor

s17t commented Dec 28, 2016

Thank you. Would mind to add some tests ? Looks at WebCrawlerTest and PageFetcherHtmlTest to see how to implement some test with wiremock.

@JCotton1123
Copy link
Contributor Author

JCotton1123 commented Dec 28, 2016 via email

@JCotton1123
Copy link
Contributor Author

Nvmd. I see now that its just mvn test.

@JCotton1123
Copy link
Contributor Author

JCotton1123 commented Jan 5, 2017

I am kind of at a loss on how to test this appropriately. I would appreciate some suggestions/advice.

@s17t s17t merged commit 4e6cdaa into yasserg:master Jan 5, 2017
s17t added a commit that referenced this pull request Jan 5, 2017
@JCotton1123 JCotton1123 deleted the 3xx-handler branch January 31, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants