Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation rules #12

Merged
merged 3 commits into from Mar 18, 2016

Conversation

Projects
None yet
3 participants
@imobachgs
Copy link
Collaborator

commented Feb 12, 2016

Integration test for bsc#963137.

These tests shouldn't be merged until the fix is merged in master.

@schubi2

This comment has been minimized.

Copy link
Member

commented Feb 12, 2016

Great ! LGMT

@imobachgs

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 12, 2016

Thanks! I'll merged it as soon as the fix is available in master (waiting for users' feedback).

@mvidner

This comment has been minimized.

Copy link
Member

commented Mar 18, 2016

IIUC yast/yast-autoinstallation#202 was the merge of the fix into master, right?

@imobachgs imobachgs force-pushed the install-rules branch from 984faa5 to a987f0e Mar 18, 2016

@imobachgs

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2016

Yes, that's it. I've rebased this PR against master again. Please, could you take a look (well, only the changes file was modified).

Thanks.

@@ -1,4 +1,10 @@
-------------------------------------------------------------------
Fri Mar 18 09:02:17 UTC 2016 - igonzalezsosa@suse.com

- Add a test to check if AutoYaST rules were correctly evaluated.

This comment has been minimized.

Copy link
@mvidner

mvidner Mar 18, 2016

Member

Please mention (bsc#963137) also here

This comment has been minimized.

Copy link
@mvidner

mvidner Mar 18, 2016

Member

Never mind, I did that.

@mvidner

This comment has been minimized.

Copy link
Member

commented Mar 18, 2016

LGTM!

imobachgs added a commit that referenced this pull request Mar 18, 2016

@imobachgs imobachgs merged commit 194290d into master Mar 18, 2016

@imobachgs imobachgs changed the title [do not merge] Installation rules Installation rules Mar 18, 2016

@imobachgs imobachgs deleted the install-rules branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.