New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly interactive workflow with addon= (fate#324656) #49

Merged
merged 3 commits into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@coveralls

This comment has been minimized.

coveralls commented Feb 2, 2018

Coverage Status

Coverage decreased (-0.03%) to 6.563% when pulling db8b21c on addon-packages-iso into f913cb6 on master.

mvidner added some commits Jan 31, 2018

Allow addon=Packages-DVD.iso (fate#324656)
copying code from the MediaSelect workflow

@mvidner mvidner changed the title from [WIP] Possibly interactive workflow with addon= (fate#324656) to Possibly interactive workflow with addon= (fate#324656) Feb 7, 2018

ensure
tmp.close
tmp.unlink
plaindir, download, name, alias_ = false, true, "", ""

This comment has been minimized.

@jreidinger

jreidinger Feb 8, 2018

Member

I expect you want to have it only for marking so I prefer in such case having it directly in call like

createSourceImpl(url, plaindir = false, download = true, name = "", alias_ = "")

This comment has been minimized.

@mvidner

mvidner Feb 8, 2018

Member

Yes, but guess what: "warning: assigned but unused variable - plaindir ..."

@jreidinger

just NP, otherwise LGTM

@mvidner mvidner merged commit 0c44e96 into master Feb 9, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 6.563%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mvidner mvidner deleted the addon-packages-iso branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment