Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoyast secure boot #581

Merged
merged 4 commits into from Sep 30, 2019
Merged

Autoyast secure boot #581

merged 4 commits into from Sep 30, 2019

Conversation

jreidinger
Copy link
Member

@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited

Coverage Status

Coverage increased (+0.06%) to 83.403% when pulling e6b3876 on autoyast_secure_boot into 928ed8e on master.

joseivanlopez
joseivanlopez approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/bootloader/autoyast_converter.rb
@@ -207,6 +220,17 @@ def bootloader_from_data(data)
end
end

# only for grub2, not for others
GRUB2EFI_BOOLEAN_MAPPING = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: Should it be a private constant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, also others are not private, so lets mark all of them as private.

joseivanlopez
joseivanlopez approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now even better. Thanks!

@jreidinger jreidinger merged commit f2427f8 into master Sep 30, 2019
@jreidinger jreidinger deleted the autoyast_secure_boot branch September 30, 2019 15:51
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #38 successfully finished
✔️ Created OBS submit request #734119

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #12 successfully finished
✔️ Created IBS submit request #202040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @yast-bot @joseivanlopez